Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2343453002: [ios] Use +[ShellEarlGrey loadURL:] for page loading in EG tests. (Closed)

Created:
4 years, 3 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 3 months ago
Reviewers:
baxley
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Use +[ShellEarlGrey loadURL:] for page loading in EG tests. Unlike web::shell_test_util::LoadUrl this new method waits until the load is completed. BUG=629116 Committed: https://crrev.com/2ad909df2d15b52492d6f924b2745062e69779ef Cr-Commit-Position: refs/heads/master@{#419231}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -39 lines) Patch
M ios/web/shell/test/context_menu_egtest.mm View 5 chunks +5 lines, -5 lines 0 comments Download
M ios/web/shell/test/meta_tags_egtest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/navigation_egtest.mm View 6 chunks +7 lines, -7 lines 0 comments Download
M ios/web/shell/test/page_state_egtest.mm View 4 chunks +3 lines, -16 lines 0 comments Download
M ios/web/shell/test/pdf_egtest.mm View 3 chunks +2 lines, -3 lines 0 comments Download
M ios/web/shell/test/plugin_placeholder_egtest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/redirect_egtest.mm View 4 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (11 generated)
Eugene But (OOO till 7-30)
4 years, 3 months ago (2016-09-14 16:32:16 UTC) #6
Eugene But (OOO till 7-30)
Mike?
4 years, 3 months ago (2016-09-16 17:58:02 UTC) #11
baxley
lgtm
4 years, 3 months ago (2016-09-16 18:03:39 UTC) #12
Eugene But (OOO till 7-30)
Thanks!
4 years, 3 months ago (2016-09-16 18:05:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343453002/20001
4 years, 3 months ago (2016-09-16 18:05:47 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 18:45:07 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 18:49:04 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ad909df2d15b52492d6f924b2745062e69779ef
Cr-Commit-Position: refs/heads/master@{#419231}

Powered by Google App Engine
This is Rietveld 408576698