ios/web/shell/test/meta_tags_egtest.mm - Issue 2343453002: [ios] Use +[ShellEarlGrey loadURL:] for page loading in EG tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/shell/test/meta_tags_egtest.mm

Issue 2343453002: [ios] Use +[ShellEarlGrey loadURL:] for page loading in EG tests. (Closed)

Patch Set: Rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/shell/test/meta_tags_egtest.mm

diff --git a/ios/web/shell/test/meta_tags_egtest.mm b/ios/web/shell/test/meta_tags_egtest.mm

index a23968f0a81d412f5769e58f0a2accaf061e39cb..ae3b926cc6bde65ec6b8e22b5a54abaa043f1816 100644

--- a/ios/web/shell/test/meta_tags_egtest.mm

+++ b/ios/web/shell/test/meta_tags_egtest.mm

@@ -8,8 +8,8 @@

#include "base/test/ios/wait_util.h"

#import "ios/web/public/test/http_server.h"

#include "ios/web/public/test/http_server_util.h"

-#include "ios/web/shell/test/app/navigation_test_util.h"

#import "ios/web/shell/test/earl_grey/shell_base_test_case.h"

+#import "ios/web/shell/test/earl_grey/shell_earl_grey.h"

#import "ios/web/shell/test/earl_grey/shell_matchers.h"

#if !defined(__has_feature) || !__has_feature(objc_arc)

@@ -66,7 +66,7 @@ using web::webViewContainingText;

responses[destinationURL] = kDestinationPage;

web::test::SetUpSimpleHttpServer(responses);

- web::shell_test_util::LoadUrl(originURL);

+ [ShellEarlGrey loadURL:originURL];

// Wait for redirect.

base::test::ios::SpinRunLoopWithMinDelay(

« no previous file with comments | « ios/web/shell/test/context_menu_egtest.mm ('k') | ios/web/shell/test/navigation_egtest.mm » ('j') | no next file with comments »