[ios] Implemented -[ShellEarlGrey loadURL:].

[ios] Implemented -[ShellEarlGrey loadURL:].

Unlike web::shell_test_util::LoadUrl this new method waits until the
load is completed.

BUG=646544
Committed: https://crrev.com/525bd4bb816e1a6b880deb2f51bff3834a86a0ee
Cr-Commit-Position: refs/heads/master@{#418604}

[Eugene But (OOO till 7-30), 2016-09-13 23:03:30]

eugenebut@chromium.org changed reviewers:
+ baxley@chromium.org

[Eugene But (OOO till 7-30), 2016-09-13 23:03:36]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[Eugene But (OOO till 7-30), 2016-09-13 23:03:37]

The CQ bit was unchecked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-09-13 23:06:29]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 23:06:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2016-09-13 23:39:53]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 23:40:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 01:22:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 01:22:17]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[baxley, 2016-09-14 15:43:26]

lgtm

https://codereview.chromium.org/2340533004/diff/40001/ios/web/public/test/ear...
File ios/web/public/test/earl_grey/js_test_util.h (right):

https://codereview.chromium.org/2340533004/diff/40001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/js_test_util.h:15: // respond to JavaScript
injection. Fails on timeout or if unrecoverable error
Should we clarify that it fails with a GREYAssert, so the caller knows what to
expect?

https://codereview.chromium.org/2340533004/diff/40001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/js_test_util.h:23: // fails.
Similar to the last comment, do you think it's good to mention GREYAssert (if
that's what the implementation does, based on my other comment)

https://codereview.chromium.org/2340533004/diff/40001/ios/web/public/test/ear...
File ios/web/public/test/earl_grey/js_test_util.mm (right):

https://codereview.chromium.org/2340533004/diff/40001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/js_test_util.mm:63: [condition
waitWithTimeout:testing::kWaitForJSCompletionTimeout];
Do we need a GREYAssertTrue on did_complete? waitWithTimeout will just continue
when timeout is reached. It returns a BOOL, so you can also assert on that.

https://github.com/google/EarlGrey/blob/master/EarlGrey/Synchronization/GREYC...

[Eugene But (OOO till 7-30), 2016-09-14 16:25:29]

Thanks!

https://codereview.chromium.org/2340533004/diff/40001/ios/web/public/test/ear...
File ios/web/public/test/earl_grey/js_test_util.h (right):

https://codereview.chromium.org/2340533004/diff/40001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/js_test_util.h:15: // respond to JavaScript
injection. Fails on timeout or if unrecoverable error
On 2016/09/14 15:43:26, baxley wrote:
> Should we clarify that it fails with a GREYAssert, so the caller knows what to
> expect?

Done.

https://codereview.chromium.org/2340533004/diff/40001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/js_test_util.h:23: // fails.
On 2016/09/14 15:43:26, baxley wrote:
> Similar to the last comment, do you think it's good to mention GREYAssert (if
> that's what the implementation does, based on my other comment)

Done.

https://codereview.chromium.org/2340533004/diff/40001/ios/web/public/test/ear...
File ios/web/public/test/earl_grey/js_test_util.mm (right):

https://codereview.chromium.org/2340533004/diff/40001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/js_test_util.mm:63: [condition
waitWithTimeout:testing::kWaitForJSCompletionTimeout];
On 2016/09/14 15:43:26, baxley wrote:
> Do we need a GREYAssertTrue on did_complete? waitWithTimeout will just
continue
> when timeout is reached. It returns a BOOL, so you can also assert on that.
> 
>
https://github.com/google/EarlGrey/blob/master/EarlGrey/Synchronization/GREYC...
Done. Original code was copy pasted from downstream :(

[Eugene But (OOO till 7-30), 2016-09-14 16:25:35]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-09-14 16:25:36]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org
Link to the patchset: https://codereview.chromium.org/2340533004/#ps60001
(title: "Addressed review comments")

[commit-bot: I haz the power, 2016-09-14 16:25:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 17:33:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-14 17:34:51]

Description was changed from

==========
[ios] Implemented -[ShellEarlGrey loadURL:].

Unlike web::shell_test_util::LoadUrl this new method waits until the
load is completed.

BUG=646544
==========

to

==========
[ios] Implemented -[ShellEarlGrey loadURL:].

Unlike web::shell_test_util::LoadUrl this new method waits until the
load is completed.

BUG=646544

Committed: https://crrev.com/525bd4bb816e1a6b880deb2f51bff3834a86a0ee
Cr-Commit-Position: refs/heads/master@{#418604}
==========

[commit-bot: I haz the power, 2016-09-14 17:34:51]

Patchset 4 (id:??) landed as
https://crrev.com/525bd4bb816e1a6b880deb2f51bff3834a86a0ee
Cr-Commit-Position: refs/heads/master@{#418604}