components/autofill/core/browser/form_structure_unittest.cc - Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/form_structure_unittest.cc

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_manager.cc ('K') | « components/autofill/core/browser/form_structure.cc ('k') | components/autofill/core/browser/test_autofill_manager_delegate.h » ('j') | components/autofill/core/common/autofill_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/form_structure_unittest.cc

diff --git a/components/autofill/core/browser/form_structure_unittest.cc b/components/autofill/core/browser/form_structure_unittest.cc

index 7d38165b4d1c440a03098cc5254ce6177963b41f..74a4897b39c845a2d85cb204e9a388e902f673b4 100644

--- a/components/autofill/core/browser/form_structure_unittest.cc

+++ b/components/autofill/core/browser/form_structure_unittest.cc

@@ -2427,6 +2427,7 @@ TEST(FormStructureTest, SkipFieldTest) {

field.label = ASCIIToUTF16("password");

field.name = ASCIIToUTF16("password");

field.form_control_type = "password";

Ilya Sherman 2013/09/03 23:58:01 nit: Please update the field type to be a checkabl

zysxqn 2013/09/04 17:26:20 Done.

+ field.is_checkable = true;

form.fields.push_back(field);

field.label = base::string16();