components/autofill/core/browser/autofill_manager.cc - Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_generation_manager.cc ('K') | « components/autofill/content/renderer/password_generation_manager.cc ('k') | components/autofill/core/browser/autofill_manager_delegate.h » ('j') | components/autofill/core/browser/form_structure_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 4c66699b8191cea5b268df8cd24d28ee40465556..280d82ec810bb1a18440ef7607faf807746f6894 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -744,6 +744,10 @@ void AutofillManager::OnLoadedServerPredictions(

page_meta_data.get(),

*metric_logger_);

+ // Forward form structures to the password generation manager (accessable from

+ // Autofill Manager Delegate) to detect account creation forms.

Ilya Sherman 2013/09/03 23:58:01 nit: IMO drop the parenthetical phrase.

zysxqn 2013/09/04 17:26:20 Done.

+ manager_delegate_->DetectAccountCreationForms(form_structures_.get());

if (page_meta_data->IsInAutofillableFlow()) {

RenderViewHost* host = driver_->GetWebContents()->GetRenderViewHost();

if (host)