Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: components/autofill/core/browser/form_structure.cc

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/form_structure.cc
diff --git a/components/autofill/core/browser/form_structure.cc b/components/autofill/core/browser/form_structure.cc
index 0a534f8d8477889ab748f377660b70fe88ba13c5..cfc57f861f77bcde5eb024a8d92d65c494bb0142 100644
--- a/components/autofill/core/browser/form_structure.cc
+++ b/components/autofill/core/browser/form_structure.cc
@@ -697,8 +697,7 @@ bool FormStructure::IsAutocheckoutEnabled() const {
}
bool FormStructure::ShouldSkipField(const FormFieldData& field) const {
- return (field.is_checkable || field.form_control_type == "password") &&
- !IsAutocheckoutEnabled();
+ return field.is_checkable && !IsAutocheckoutEnabled();
}
size_t FormStructure::RequiredFillableFields() const {

Powered by Google App Engine
This is Rietveld 408576698