Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: components/autofill/core/browser/autofill_type.cc

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_type.cc
diff --git a/components/autofill/core/browser/autofill_type.cc b/components/autofill/core/browser/autofill_type.cc
index f1e280ba9d8cf5e93b63a863e7a14a2f9cf4ceba..97168acffdfb2064ad7a44220db10c6ca7a1e2ed 100644
--- a/components/autofill/core/browser/autofill_type.cc
+++ b/components/autofill/core/browser/autofill_type.cc
@@ -108,6 +108,10 @@ FieldTypeGroup AutofillType::group() const {
case COMPANY_NAME:
return COMPANY;
+ case PASSWORD:
+ case ACCOUNT_CREATION_PASSWORD:
+ return PASSWORD_FIELD;
+
case NO_SERVER_DATA:
case EMPTY_TYPE:
case PHONE_FAX_NUMBER:
@@ -116,6 +120,8 @@ FieldTypeGroup AutofillType::group() const {
case PHONE_FAX_CITY_AND_NUMBER:
case PHONE_FAX_WHOLE_NUMBER:
case FIELD_WITH_DEFAULT_VALUE:
+ case MERCHANT_EMAIL_SIGNUP:
+ case MERCHANT_PROMO_CODE:
return NO_GROUP;
case MAX_VALID_FIELD_TYPE:
@@ -529,6 +535,14 @@ std::string AutofillType::ToString() const {
return "PHONE_BILLING_CITY_AND_NUMBER";
case PHONE_BILLING_WHOLE_NUMBER:
return "PHONE_BILLING_WHOLE_NUMBER";
+ case MERCHANT_EMAIL_SIGNUP:
+ return "MERCHANT_EMAIL_SIGNUP";
+ case MERCHANT_PROMO_CODE:
+ return "MERCHANT_PROMO_CODE";
+ case PASSWORD:
+ return "PASSWORD";
+ case ACCOUNT_CREATION_PASSWORD:
+ return "ACCOUNT_CREATION_PASSWORD";
case MAX_VALID_FIELD_TYPE:
return std::string();
}

Powered by Google App Engine
This is Rietveld 408576698