Generate passwords only for forms that autofill server marks as account creation forms.

components/autofill/core/browser/form_structure.h

Index: components/autofill/core/browser/form_structure.h
diff --git a/components/autofill/core/browser/form_structure.h b/components/autofill/core/browser/form_structure.h
index 1af765057c25ac7c2d127f9323e8bae3e85003cc..0eebbe0d29980fa798801f38555b6444adc30c75 100644
--- a/components/autofill/core/browser/form_structure.h
+++ b/components/autofill/core/browser/form_structure.h
@@ -36,6 +36,8 @@ namespace buzz {
 class XmlElement;
 }
 
+FORWARD_DECLARE_TEST(PasswordGenerationManagerTest, DetectAccountCreationForms);
+
 namespace autofill {
 
 class AutofillMetrics;
@@ -174,6 +176,8 @@ class FormStructure {
 
  private:
   friend class FormStructureTest;
+  FRIEND_TEST_ALL_PREFIXES(::PasswordGenerationManagerTest,
+                           DetectAccountCreationForms);

[Ilya Sherman, 2013/08/29 23:08:13]

What exactly do you need to use from the private section of this class?  It's
better to find other ways to expose that information than friending tests,
especially given that the test that you're friending is defined outside of the
autofill component.

[zysxqn, 2013/09/03 23:00:20]

Done.

   FRIEND_TEST_ALL_PREFIXES(AutofillDownloadTest, QueryAndUploadTest);
 
   // 64-bit hash of the string - used in FormSignature and unit-tests.