Generate passwords only for forms that autofill server marks as account creation forms.

components/autofill/core/browser/field_types.h

Index: components/autofill/core/browser/field_types.h
diff --git a/components/autofill/core/browser/field_types.h b/components/autofill/core/browser/field_types.h
index 081a7a75c42c092b4200d7b1806410d98b1b6ae5..96c450328da070ba15efd6c59e8db16eb68098ca 100644
--- a/components/autofill/core/browser/field_types.h
+++ b/components/autofill/core/browser/field_types.h
@@ -99,10 +99,19 @@ enum ServerFieldType {
   NAME_BILLING_FULL = 71,
   NAME_BILLING_SUFFIX = 72,
 
+  // Field types for options generally found in merchant buyflows. Given that
+  // these are likely to be filled out differently on a case by case basis,
+  // they are here primarly for use by Autocheckout.

[Garrett Casto, 2013/08/29 22:45:13]

Were these changes that had been made on the server side that hadn't been made
in Chrome yet?

[zysxqn, 2013/09/03 23:00:20]

Yes.

+  MERCHANT_EMAIL_SIGNUP = 73,
+  MERCHANT_PROMO_CODE = 74,

[Ilya Sherman, 2013/08/29 23:08:13]

Why are these being added as part of this CL?  They don't seem relevant to the
change that you're making, and Autocheckout is deprecated.

[zysxqn, 2013/09/03 23:00:20]

They have been added on the server side but haven't used anywhere in the client
side. To keep them consistent I have to add them here.

+
+  PASSWORD = 75,

[Garrett Casto, 2013/08/29 22:45:13]

These probably deserve a comment. Something like "Field types for password
fields. ACCOUNT_CREATION_PASSWORD fields can trigger password generation."
(wording is pretty rough, feel free to clean it up).

[zysxqn, 2013/09/03 23:00:20]

Done.

+  ACCOUNT_CREATION_PASSWORD = 76,

[Ilya Sherman, 2013/08/29 23:08:13]

Seems like PASSWORD should be less generic given that another option is the more
specific ACCOUNT_CREATION_PASSWORD.

[Ilya Sherman, 2013/08/29 23:08:13]

Have these changes already been made on the server side?

[zysxqn, 2013/09/03 23:00:20]

I think it is by design. We will vote a password field as PASSWORD every time we
submit a password form. We will then vote a password field (should already be
marked as PASSWORD) as ACCOUNT_CREATION_PASSWORD when we have more evidence that
it is an account creation password (i.e. when it is first used to login). So
PASSWORD type should be more generic.

[zysxqn, 2013/09/03 23:00:20]

Yes.

+
   // No new types can be added without a corresponding change to the Autofill
   // server.
 
-  MAX_VALID_FIELD_TYPE = 73,
+  MAX_VALID_FIELD_TYPE = 77,
 };
 
 // The list of all HTML autocomplete field type hints supported by Chrome.
@@ -181,6 +190,7 @@ enum FieldTypeGroup {
   PHONE_HOME,
   PHONE_BILLING,
   CREDIT_CARD,
+  PASSWORD_FIELD,

[Ilya Sherman, 2013/08/29 23:08:13]

nit: This would be a more appropriate place to use the constant name PASSWORD.

[zysxqn, 2013/09/03 23:00:20]

See my comments above. Are you fine with leave it as is. If later we find better
naming we can submit a CL to change all of them altogether consistently.

 };
 
 typedef std::set<ServerFieldType> ServerFieldTypeSet;