Generate passwords only for forms that autofill server marks as account creation forms.

components/autofill/core/browser/form_structure.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 18 matching lines @@
 };
 
 namespace base {
 class TimeTicks;
 }
 
 namespace buzz {
 class XmlElement;
 }
 
+FORWARD_DECLARE_TEST(PasswordGenerationManagerTest, DetectAccountCreationForms);
+
 namespace autofill {
 
 class AutofillMetrics;
 
 struct AutocheckoutPageMetaData;
 struct FormData;
 struct FormDataPredictions;
 
 // FormStructure stores a single HTML form together with the values entered
 // in the fields along with additional information needed by Autofill.
@@ skipping 118 matching lines @@
   bool filled_by_autocheckout() const { return filled_by_autocheckout_; }
   void set_filled_by_autocheckout(bool filled_by_autocheckout) {
     filled_by_autocheckout_ = filled_by_autocheckout;
   }
 
   bool operator==(const FormData& form) const;
   bool operator!=(const FormData& form) const;
 
  private:
   friend class FormStructureTest;
+  FRIEND_TEST_ALL_PREFIXES(::PasswordGenerationManagerTest,
+                           DetectAccountCreationForms);

[Ilya Sherman, 2013/08/29 23:08:13]

What exactly do you need to use from the private section of this class?  It's
better to find other ways to expose that information than friending tests,
especially given that the test that you're friending is defined outside of the
autofill component.

[zysxqn, 2013/09/03 23:00:20]

Done.

   FRIEND_TEST_ALL_PREFIXES(AutofillDownloadTest, QueryAndUploadTest);
 
   // 64-bit hash of the string - used in FormSignature and unit-tests.
   static std::string Hash64Bit(const std::string& str);
 
   enum EncodeRequestType {
     QUERY,
     UPLOAD,
     FIELD_ASSIGNMENTS,
   };
@@ skipping 66 matching lines @@
 
   // Whether or not this form was filled by Autocheckout.
   bool filled_by_autocheckout_;
 
   DISALLOW_COPY_AND_ASSIGN(FormStructure);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_