[TypeFeedbackVector] special ic slots for interpreter compare/binary ops.

[TypeFeedbackVector] special ic slots for interpreter compare/binary ops.

Full code uses patching ICs for this feedback, and the interpreter uses
the type feedback vector. It's a good idea to code the vector slots
appropriately as ICs so that the runtime profiler can better gauge if
the function is ready for tiering up from Ignition to TurboFan.

As is, the feedback is stored in "general" slots which can't be
characterized by the runtime profiler into feedback states.

This CL addresses that problem. Note that it's also important to
carefully exclude these slots from the profiler's consideration when
determining if you want to optimize from Full code.

BUG=

Committed: https://crrev.com/b88d132f4cbc4a7f4de106542ae5895079049070
Cr-Commit-Position: refs/heads/master@{#39555}

[mvstanton, 2016-09-20 11:47:41]

mvstanton@chromium.org changed reviewers:
+ bmeurer@chromium.org, mythria@chromium.org

[mvstanton, 2016-09-20 11:47:42]

Hi Mythri, hi Benedikt,

Here is the change we discussed. Thanks for the look!
--Mike

[mvstanton, 2016-09-20 11:51:32]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 11:51:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-09-20 11:52:35]

LGTM from my side.

https://codereview.chromium.org/2342853002/diff/20001/src/type-feedback-vecto...
File src/type-feedback-vector.cc (right):

https://codereview.chromium.org/2342853002/diff/20001/src/type-feedback-vecto...
src/type-feedback-vector.cc:206: return "iINTERPRETER_BINARYOP_IC";
Nit: Remove the leading i :-)

https://codereview.chromium.org/2342853002/diff/20001/src/type-feedback-vecto...
src/type-feedback-vector.cc:208: return "iINTERPRETER_COMPARE_IC";
Nit: Remove the leading i :-)

[commit-bot: I haz the power, 2016-09-20 11:55:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 11:55:46]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24476)

[mythria, 2016-09-20 12:35:16]

Thanks, lgtm with a minor comment.

https://codereview.chromium.org/2342853002/diff/40001/src/objects-printer.cc
File src/objects-printer.cc (right):

https://codereview.chromium.org/2342853002/diff/40001/src/objects-printer.cc#...
src/objects-printer.cc:754: case FeedbackVectorSlotKind::INTERPRETER_COMPARE_IC:
Would it be helpful to print the binary/compare operation hint here for
debugging or performance analysis?

[mvstanton, 2016-09-20 13:19:23]

Thanks, addressed y'alls comments. Uploading...
--Mike

https://codereview.chromium.org/2342853002/diff/40001/src/objects-printer.cc
File src/objects-printer.cc (right):

https://codereview.chromium.org/2342853002/diff/40001/src/objects-printer.cc#...
src/objects-printer.cc:754: case FeedbackVectorSlotKind::INTERPRETER_COMPARE_IC:
On 2016/09/20 12:35:16, mythria wrote:
> Would it be helpful to print the binary/compare operation hint here for
> debugging or performance analysis?

Absolutely, will do!

[mvstanton, 2016-09-20 13:19:28]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2016-09-20 13:19:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mythria@chromium.org
Link to the patchset: https://codereview.chromium.org/2342853002/#ps60001
(title: "Code comments.")

[commit-bot: I haz the power, 2016-09-20 13:19:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 13:53:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-20 13:54:57]

Description was changed from

==========
[TypeFeedbackVector] special ic slots for interpreter compare/binary ops.

Full code uses patching ICs for this feedback, and the interpreter uses
the type feedback vector. It's a good idea to code the vector slots
appropriately as ICs so that the runtime profiler can better gauge if
the function is ready for tiering up from Ignition to TurboFan.

As is, the feedback is stored in "general" slots which can't be
characterized by the runtime profiler into feedback states.

This CL addresses that problem. Note that it's also important to
carefully exclude these slots from the profiler's consideration when
determining if you want to optimize from Full code.

BUG=
==========

to

==========
[TypeFeedbackVector] special ic slots for interpreter compare/binary ops.

Full code uses patching ICs for this feedback, and the interpreter uses
the type feedback vector. It's a good idea to code the vector slots
appropriately as ICs so that the runtime profiler can better gauge if
the function is ready for tiering up from Ignition to TurboFan.

As is, the feedback is stored in "general" slots which can't be
characterized by the runtime profiler into feedback states.

This CL addresses that problem. Note that it's also important to
carefully exclude these slots from the profiler's consideration when
determining if you want to optimize from Full code.

BUG=

Committed: https://crrev.com/b88d132f4cbc4a7f4de106542ae5895079049070
Cr-Commit-Position: refs/heads/master@{#39555}
==========

[commit-bot: I haz the power, 2016-09-20 13:54:58]

Patchset 4 (id:??) landed as
https://crrev.com/b88d132f4cbc4a7f4de106542ae5895079049070
Cr-Commit-Position: refs/heads/master@{#39555}

[Benedikt Meurer, 2016-09-20 17:15:00]

https://codereview.chromium.org/2342853002/diff/60001/src/type-feedback-vecto...
File src/type-feedback-vector-inl.h (right):

https://codereview.chromium.org/2342853002/diff/60001/src/type-feedback-vecto...
src/type-feedback-vector-inl.h:173: if (code_is_interpreted) continue;
Ops, this is missing an exclamation mark.