Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: src/compiler/type-hint-analyzer.cc

Issue 2342853002: [TypeFeedbackVector] special ic slots for interpreter compare/binary ops. (Closed)
Patch Set: Code comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/type-hint-analyzer.cc
diff --git a/src/compiler/type-hint-analyzer.cc b/src/compiler/type-hint-analyzer.cc
index 2df2b280d9f01a2c5fb99f2a6c9e3601dc42ef28..a668a48ad8fcf44c800fa3dbb7f0a958e04a03a3 100644
--- a/src/compiler/type-hint-analyzer.cc
+++ b/src/compiler/type-hint-analyzer.cc
@@ -6,8 +6,8 @@
#include "src/assembler.h"
#include "src/code-stubs.h"
-#include "src/compiler/type-hints.h"
#include "src/ic/ic-state.h"
+#include "src/type-hints.h"
namespace v8 {
namespace internal {
@@ -136,32 +136,6 @@ TypeHintAnalysis* TypeHintAnalyzer::Analyze(Handle<Code> code) {
return new (zone()) TypeHintAnalysis(infos, zone());
}
-// Helper function to transform the feedback to BinaryOperationHint.
-BinaryOperationHint BinaryOperationHintFromFeedback(int type_feedback) {
- switch (type_feedback) {
- case BinaryOperationFeedback::kSignedSmall:
- return BinaryOperationHint::kSignedSmall;
- case BinaryOperationFeedback::kNumber:
- return BinaryOperationHint::kNumberOrOddball;
- case BinaryOperationFeedback::kAny:
- default:
- return BinaryOperationHint::kAny;
- }
- UNREACHABLE();
- return BinaryOperationHint::kNone;
-}
-
-// Helper function to transform the feedback to CompareOperationHint.
-CompareOperationHint CompareOperationHintFromFeedback(int type_feedback) {
- switch (type_feedback) {
- case CompareOperationFeedback::kSignedSmall:
- return CompareOperationHint::kSignedSmall;
- case CompareOperationFeedback::kNumber:
- return CompareOperationHint::kNumber;
- default:
- return CompareOperationHint::kAny;
- }
-}
} // namespace compiler
} // namespace internal

Powered by Google App Engine
This is Rietveld 408576698