Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Unified Diff: src/ast/ast.cc

Issue 2342853002: [TypeFeedbackVector] special ic slots for interpreter compare/binary ops. (Closed)
Patch Set: Code comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ast/ast.cc
diff --git a/src/ast/ast.cc b/src/ast/ast.cc
index 8d50b7c1c4f526e1203b7fe2792cf926a32cf5f4..4fbbd2a44d9fa95064e76b3c621836dcad7f85d9 100644
--- a/src/ast/ast.cc
+++ b/src/ast/ast.cc
@@ -269,7 +269,7 @@ void CountOperation::AssignFeedbackVectorSlots(Isolate* isolate,
AssignVectorSlots(expression(), spec, &slot_);
// Assign a slot to collect feedback about binary operations. Used only in
// ignition. Fullcodegen uses AstId to record type feedback.
- binary_operation_slot_ = spec->AddGeneralSlot();
+ binary_operation_slot_ = spec->AddInterpreterBinaryOpICSlot();
}
@@ -719,7 +719,7 @@ void BinaryOperation::AssignFeedbackVectorSlots(
case Token::OR:
return;
default:
- type_feedback_slot_ = spec->AddGeneralSlot();
+ type_feedback_slot_ = spec->AddInterpreterBinaryOpICSlot();
return;
}
}
@@ -740,7 +740,7 @@ void CompareOperation::AssignFeedbackVectorSlots(
case Token::IN:
return;
default:
- type_feedback_slot_ = spec->AddGeneralSlot();
+ type_feedback_slot_ = spec->AddInterpreterCompareICSlot();
}
}
@@ -947,7 +947,7 @@ CaseClause::CaseClause(Expression* label, ZoneList<Statement*>* statements,
void CaseClause::AssignFeedbackVectorSlots(Isolate* isolate,
FeedbackVectorSpec* spec,
FeedbackVectorSlotCache* cache) {
- type_feedback_slot_ = spec->AddGeneralSlot();
+ type_feedback_slot_ = spec->AddInterpreterCompareICSlot();
}
uint32_t Literal::Hash() {
« no previous file with comments | « BUILD.gn ('k') | src/code-stub-assembler.cc » ('j') | src/type-feedback-vector-inl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698