[Offline pages] Clean up unnecessary DeleteAll calls in offline internals

[Offline pages] Clean up unnecessary DeleteAll calls in offline internals

-- The DeleteAllPages method is only used by the offline internals page.
-- The Javascript can send all the request ids for DeleteAllRequests to eliminate additional async callback complexity.
-- Update IDs to be less confusing.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2d109e491d8fe83601445a0d8f2e3855a74ad3d7
Cr-Commit-Position: refs/heads/master@{#418968}

[chili, 2016-09-14 18:19:40]

Description was changed from

==========
[Offline pages] Clean up unnecessary DeleteAll calls in offline internals

The DeleteAllPages method is only used by the offline internals page.
The Javascript can send all the request ids for DeleteAllRequests to eliminate
additional async callback complexity.

BUG=
==========

to

==========
[Offline pages] Clean up unnecessary DeleteAll calls in offline internals

The DeleteAllPages method is only used by the offline internals page.
The Javascript can send all the request ids for DeleteAllRequests to eliminate
additional async callback complexity.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[chili, 2016-09-14 18:21:16]

Description was changed from

==========
[Offline pages] Clean up unnecessary DeleteAll calls in offline internals

The DeleteAllPages method is only used by the offline internals page.
The Javascript can send all the request ids for DeleteAllRequests to eliminate
additional async callback complexity.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Offline pages] Clean up unnecessary DeleteAll calls in offline internals

-- The DeleteAllPages method is only used by the offline internals page.
-- The Javascript can send all the request ids for DeleteAllRequests to
eliminate additional async callback complexity.
-- Update IDs to be less confusing.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[chili, 2016-09-14 18:21:52]

chili@chromium.org changed reviewers:
+ dewittj@chromium.org, petewil@chromium.org

[dewittj, 2016-09-14 18:39:10]

lgtm, thanks!

https://codereview.chromium.org/2342603004/diff/1/chrome/browser/resources/of...
File chrome/browser/resources/offline_pages/offline_internals.html (right):

https://codereview.chromium.org/2342603004/diff/1/chrome/browser/resources/of...
chrome/browser/resources/offline_pages/offline_internals.html:43: <button
id="delete-all-pages">Clear all</button>
nit: why move to "delete" when the model uses "clear" for this action?

[chili, 2016-09-14 18:47:07]

https://codereview.chromium.org/2342603004/diff/1/chrome/browser/resources/of...
File chrome/browser/resources/offline_pages/offline_internals.html (right):

https://codereview.chromium.org/2342603004/diff/1/chrome/browser/resources/of...
chrome/browser/resources/offline_pages/offline_internals.html:43: <button
id="delete-all-pages">Clear all</button>
On 2016/09/14 18:39:10, dewittj wrote:
> nit: why move to "delete" when the model uses "clear" for this action?

Request queue uses delete (line 62-63).  Whenever I see 'clear' here and
'delete' in request queue, I would wonder if there's some fundamental difference
between 'delete' and 'clear', and I'd be tempted to make them the same.

I will update the button text as well (missed that)

[dewittj, 2016-09-14 18:49:06]

I think that for offline pages we support the 2-step delete process, which is
unsupported for requests in the queue.

[chili, 2016-09-14 20:00:45]

On 2016/09/14 18:49:06, dewittj wrote:
> I think that for offline pages we support the 2-step delete process, which is
> unsupported for requests in the queue.

As discussed offline, delete and clear do not go through the 2-step delete
process.  The pages are actually wiped, so delete should be the correct
terminology.  Updated button text to match.

[Pete Williamson, 2016-09-15 00:30:57]

lgtm.  Much nicer than what we had before, thanks!

[chili, 2016-09-15 00:35:55]

chili@chromium.org changed reviewers:
+ bauerb@chromium.org

[chili, 2016-09-15 00:35:55]

+bauerb for OWNER

[Bernhard Bauer, 2016-09-15 08:36:28]

https://codereview.chromium.org/2342603004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/offline_pages/offline_internals.js (right):

https://codereview.chromium.org/2342603004/diff/20001/chrome/browser/resource...
chrome/browser/resources/offline_pages/offline_internals.js:135:
selectedIds.push(checkboxes[i].value);
Indent two spaces.

[Bernhard Bauer, 2016-09-15 08:48:59]

Oops, otherwise LGTM :)

[chili, 2016-09-15 18:18:26]

Thanks!

https://codereview.chromium.org/2342603004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/offline_pages/offline_internals.js (right):

https://codereview.chromium.org/2342603004/diff/20001/chrome/browser/resource...
chrome/browser/resources/offline_pages/offline_internals.js:135:
selectedIds.push(checkboxes[i].value);
On 2016/09/15 08:36:28, Bernhard Bauer wrote:
> Indent two spaces.

Done.

[chili, 2016-09-15 18:44:14]

The CQ bit was checked by chili@chromium.org

[chili, 2016-09-15 18:44:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
dewittj@chromium.org, bauerb@chromium.org, petewil@chromium.org
Link to the patchset: https://codereview.chromium.org/2342603004/#ps60001
(title: "update id in js and remove references to deleted methods")

[commit-bot: I haz the power, 2016-09-15 18:44:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 18:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 18:58:40]

Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Dan Beam, 2016-09-15 20:32:45]

On 2016/09/15 18:58:40, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

restarted a closure_compilation try job for you, this should be fixed now

[chili, 2016-09-15 20:48:26]

The CQ bit was checked by chili@chromium.org

[chili, 2016-09-15 20:48:46]

On 2016/09/15 20:32:45, Dan Beam wrote:
> On 2016/09/15 18:58:40, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
> 
> restarted a closure_compilation try job for you, this should be fixed now

yay! thank you ^__^

[commit-bot: I haz the power, 2016-09-15 20:48:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 20:56:52]

Description was changed from

==========
[Offline pages] Clean up unnecessary DeleteAll calls in offline internals

-- The DeleteAllPages method is only used by the offline internals page.
-- The Javascript can send all the request ids for DeleteAllRequests to
eliminate additional async callback complexity.
-- Update IDs to be less confusing.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Offline pages] Clean up unnecessary DeleteAll calls in offline internals

-- The DeleteAllPages method is only used by the offline internals page.
-- The Javascript can send all the request ids for DeleteAllRequests to
eliminate additional async callback complexity.
-- Update IDs to be less confusing.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-15 20:56:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-15 21:00:07]

Description was changed from

==========
[Offline pages] Clean up unnecessary DeleteAll calls in offline internals

-- The DeleteAllPages method is only used by the offline internals page.
-- The Javascript can send all the request ids for DeleteAllRequests to
eliminate additional async callback complexity.
-- Update IDs to be less confusing.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Offline pages] Clean up unnecessary DeleteAll calls in offline internals

-- The DeleteAllPages method is only used by the offline internals page.
-- The Javascript can send all the request ids for DeleteAllRequests to
eliminate additional async callback complexity.
-- Update IDs to be less confusing.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2d109e491d8fe83601445a0d8f2e3855a74ad3d7
Cr-Commit-Position: refs/heads/master@{#418968}
==========

[commit-bot: I haz the power, 2016-09-15 21:00:15]

Patchset 4 (id:??) landed as
https://crrev.com/2d109e491d8fe83601445a0d8f2e3855a74ad3d7
Cr-Commit-Position: refs/heads/master@{#418968}