[Offline pages] Clean up unnecessary DeleteAll calls in offline internals

chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h"
 
 #include <stdint.h>
 #include <stdlib.h>
 #include <vector>
 
@@ skipping 46 matching lines @@
     }
   }
 
   return "Success";
 }
 
 std::string OfflineInternalsUIMessageHandler::GetStringFromSavePageStatus() {
   return "Available";
 }
 
-void OfflineInternalsUIMessageHandler::HandleDeleteAllPages(
-    const base::ListValue* args) {
-  std::string callback_id;
-  CHECK(args->GetString(0, &callback_id));
-
-  // Pass back success because ClearAll doesn't return a status.
-  offline_page_model_->ClearAll(
-      base::Bind(&OfflineInternalsUIMessageHandler::HandleDeletedPagesCallback,
-                 weak_ptr_factory_.GetWeakPtr(), callback_id,
-                 offline_pages::DeletePageResult::SUCCESS));
-}
-
 void OfflineInternalsUIMessageHandler::HandleDeleteSelectedPages(
     const base::ListValue* args) {
   std::string callback_id;
   CHECK(args->GetString(0, &callback_id));
 
   std::vector<int64_t> offline_ids;
   const base::ListValue* offline_ids_from_arg;
   args->GetList(1, &offline_ids_from_arg);
 
   for (size_t i = 0; i < offline_ids_from_arg->GetSize(); i++) {
     std::string value;
     offline_ids_from_arg->GetString(i, &value);
     int64_t int_value;
     base::StringToInt64(value, &int_value);
     offline_ids.push_back(int_value);
   }
 
   offline_page_model_->DeletePagesByOfflineId(
       offline_ids,
       base::Bind(&OfflineInternalsUIMessageHandler::HandleDeletedPagesCallback,
                  weak_ptr_factory_.GetWeakPtr(), callback_id));
 }
 
-void OfflineInternalsUIMessageHandler::HandleDeleteAllRequests(
-    const base::ListValue* args) {
-  std::string callback_id;
-  CHECK(args->GetString(0, &callback_id));
-  // First do a get, then in the callback, build a list of IDs, and
-  // call RemoveRequests with that list.
-  if (request_coordinator_) {
-    request_coordinator_->GetAllRequests(
-        base::Bind(&OfflineInternalsUIMessageHandler::
-                       HandleGetAllRequestsForDeleteCallback,
-                   weak_ptr_factory_.GetWeakPtr(), callback_id));
-  }
-}
-
 void OfflineInternalsUIMessageHandler::HandleDeleteSelectedRequests(
     const base::ListValue* args) {
   std::string callback_id;
   CHECK(args->GetString(0, &callback_id));
 
   std::vector<int64_t> offline_ids;
   const base::ListValue* offline_ids_from_arg = nullptr;
   args->GetList(1, &offline_ids_from_arg);
 
   for (size_t i = 0; i < offline_ids_from_arg->GetSize(); i++) {
     std::string value;
     offline_ids_from_arg->GetString(i, &value);
     int64_t int_value;
     base::StringToInt64(value, &int_value);
     offline_ids.push_back(int_value);
   }
 
   // Call RequestCoordinator to delete them
   if (request_coordinator_) {
     request_coordinator_->RemoveRequests(
         offline_ids,
         base::Bind(
             &OfflineInternalsUIMessageHandler::HandleDeletedRequestsCallback,
             weak_ptr_factory_.GetWeakPtr(), callback_id));
   }
 }
 
-void OfflineInternalsUIMessageHandler::HandleGetAllRequestsForDeleteCallback(
-    std::string callback_id,
-    std::vector<std::unique_ptr<offline_pages::SavePageRequest>> requests) {
-  std::vector<int64_t> offline_ids;
-  // Build a list of offline_ids from the requests.
-  for (const auto& request : requests) {
-    offline_ids.push_back(request->request_id());
-  }
-
-  // Call RequestCoordinator to delete them
-  if (request_coordinator_) {
-    request_coordinator_->RemoveRequests(
-        offline_ids,
-        base::Bind(
-            &OfflineInternalsUIMessageHandler::HandleDeletedRequestsCallback,
-            weak_ptr_factory_.GetWeakPtr(), callback_id));
-  }
-}
-
 void OfflineInternalsUIMessageHandler::HandleDeletedPagesCallback(
     std::string callback_id,
     offline_pages::DeletePageResult result) {
   ResolveJavascriptCallback(
       base::StringValue(callback_id),
       base::StringValue(GetStringFromDeletePageResult(result)));
 }
 
 void OfflineInternalsUIMessageHandler::HandleDeletedRequestsCallback(
     std::string callback_id,
@@ skipping 163 matching lines @@
             GURL(url), offline_pages::ClientId(offline_pages::kAsyncNamespace,
                                                id_stream.str()),
             true)));
   } else {
     ResolveJavascriptCallback(*callback_id, base::FundamentalValue(false));
   }
 }
 
 void OfflineInternalsUIMessageHandler::RegisterMessages() {
   web_ui()->RegisterMessageCallback(
-      "deleteAllPages",
-      base::Bind(&OfflineInternalsUIMessageHandler::HandleDeleteAllPages,
-                 weak_ptr_factory_.GetWeakPtr()));
-  web_ui()->RegisterMessageCallback(
       "deleteSelectedPages",
       base::Bind(&OfflineInternalsUIMessageHandler::HandleDeleteSelectedPages,
                  weak_ptr_factory_.GetWeakPtr()));
   web_ui()->RegisterMessageCallback(
-      "deleteAllRequests",
-      base::Bind(&OfflineInternalsUIMessageHandler::HandleDeleteAllRequests,
-                 weak_ptr_factory_.GetWeakPtr()));
-  web_ui()->RegisterMessageCallback(
       "deleteSelectedRequests",
       base::Bind(
           &OfflineInternalsUIMessageHandler::HandleDeleteSelectedRequests,
           weak_ptr_factory_.GetWeakPtr()));
   web_ui()->RegisterMessageCallback(
       "getRequestQueue",
       base::Bind(&OfflineInternalsUIMessageHandler::HandleGetRequestQueue,
                  weak_ptr_factory_.GetWeakPtr()));
   web_ui()->RegisterMessageCallback(
       "getStoredPages",
@@ skipping 26 matching lines @@
 
   // Get the offline page model associated with this web ui.
   Profile* profile = Profile::FromWebUI(web_ui());
   offline_page_model_ =
       offline_pages::OfflinePageModelFactory::GetForBrowserContext(profile);
   request_coordinator_ =
       offline_pages::RequestCoordinatorFactory::GetForBrowserContext(profile);
 }
 
 }  // namespace offline_internals