Chromium Code Reviews Chromium Code Reviews
Issue 2342603004:
[Offline pages] Clean up unnecessary DeleteAll calls in offline internals (Closed)
| OLD | NEW |
|---|---|
| 1 <!doctype html> | 1 <!doctype html> |
| 2 <html lang="en" dir="ltr"> | 2 <html lang="en" dir="ltr"> |
| 3 <head> | 3 <head> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <title>Offline Internals</title> | 5 <title>Offline Internals</title> |
| 6 <meta name="viewport" content="width=device-width"> | 6 <meta name="viewport" content="width=device-width"> |
| 7 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> | 7 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> |
| 8 <link rel="stylesheet" href="offline_internals.css"> | 8 <link rel="stylesheet" href="offline_internals.css"> |
| 9 | 9 |
| 10 <link rel="import" href="chrome://resources/html/cr.html"> | 10 <link rel="import" href="chrome://resources/html/cr.html"> |
| (...skipping 22 matching lines...) Expand all Loading... | |
| 33 <div> | 33 <div> |
| 34 Request Queue Log: <span id="request-status"></span> | 34 Request Queue Log: <span id="request-status"></span> |
| 35 <button id="log-request-on">Enable</button> | 35 <button id="log-request-on">Enable</button> |
| 36 <button id="log-request-off">Disable</button> | 36 <button id="log-request-off">Disable</button> |
| 37 </div> | 37 </div> |
| 38 <ul id="logs"></ul> | 38 <ul id="logs"></ul> |
| 39 </div> | 39 </div> |
| 40 | 40 |
| 41 <h2>Stored Pages</h2> | 41 <h2>Stored Pages</h2> |
| 42 <div> | 42 <div> |
| 43 <button id="clear-all">Clear all</button> | 43 <button id="delete-all-pages">Clear all</button> |
|
dewittj
2016/09/14 18:39:10
nit: why move to "delete" when the model uses "cle
chili
2016/09/14 18:47:07
Request queue uses delete (line 62-63). Whenever
| |
| 44 <button id="clear-selected">Clear selected</button> | 44 <button id="delete-selected-pages">Clear selected</button> |
| 45 </div> | 45 </div> |
| 46 <table class="stored-pages-table"> | 46 <table class="stored-pages-table"> |
| 47 <thead> | 47 <thead> |
| 48 <tr> | 48 <tr> |
| 49 <th> </th> | 49 <th> </th> |
| 50 <th>URL</th> | 50 <th>URL</th> |
| 51 <th>Namespace</th> | 51 <th>Namespace</th> |
| 52 <th>Size (Kb)</th> | 52 <th>Size (Kb)</th> |
| 53 <th>Expired</th> | 53 <th>Expired</th> |
| 54 </tr> | 54 </tr> |
| (...skipping 18 matching lines...) Expand all Loading... | |
| 73 </thead> | 73 </thead> |
| 74 <tbody id="request-queue"> </tbody> | 74 <tbody id="request-queue"> </tbody> |
| 75 </table> | 75 </table> |
| 76 <div id="request-queue-actions-info"></div> | 76 <div id="request-queue-actions-info"></div> |
| 77 <input id="url" type="url" | 77 <input id="url" type="url" |
| 78 placeholder="http://www.url1.com, http://www.url2.com, ..."> | 78 placeholder="http://www.url1.com, http://www.url2.com, ..."> |
| 79 <button id="add-to-queue">Load in background</button> | 79 <button id="add-to-queue">Load in background</button> |
| 80 <div id="save-url-state"></div> | 80 <div id="save-url-state"></div> |
| 81 </body> | 81 </body> |
| 82 </html> | 82 </html> |
| OLD | NEW |
