Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Unified Diff: ui/accessibility/platform/ax_platform_node_delegate.h

Issue 2341633006: MacViews/a11y: Allow accessibility clients to update the selected text. (Closed)
Patch Set: Make set value callbacks not have a const bool |replace| arg. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/accessibility/platform/ax_platform_node_delegate.h
diff --git a/ui/accessibility/platform/ax_platform_node_delegate.h b/ui/accessibility/platform/ax_platform_node_delegate.h
index 1e27f3f00a09f5d3754b07db46ada6405b934882..e89773bc80911adc9dd034246fd7627d3d6c57ea 100644
--- a/ui/accessibility/platform/ax_platform_node_delegate.h
+++ b/ui/accessibility/platform/ax_platform_node_delegate.h
@@ -85,9 +85,12 @@ class AX_EXPORT AXPlatformNodeDelegate {
virtual void DoDefaultAction() = 0;
// Change the value of a control, such as the text content of a text field.
- virtual bool SetStringValue(const base::string16& new_value) = 0;
+ // Optionally replace it or insert at the cursor if |replace| is true.
dmazzoni 2016/10/25 17:21:49 Same here, flip the boolean around and rename it s
Patti Lor 2016/10/26 00:57:15 Done.
+ virtual bool SetStringValue(const base::string16& new_value,
+ bool replace) = 0;
- // Whether the string value is settable.
+ // Whether SetStringValue() and ReplaceSelectedText() are callable, i.e. if
+ // the string value is read only and if the callback exists.
virtual bool CanSetStringValue() = 0;
};

Powered by Google App Engine
This is Rietveld 408576698