Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: ui/accessibility/platform/ax_platform_node_delegate.h

Issue 2341633006: MacViews/a11y: Allow accessibility clients to update the selected text. (Closed)
Patch Set: Make set value callbacks not have a const bool |replace| arg. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_ACCESSIBILITY_PLATFORM_AX_PLATFORM_NODE_DELEGATE_H_ 5 #ifndef UI_ACCESSIBILITY_PLATFORM_AX_PLATFORM_NODE_DELEGATE_H_
6 #define UI_ACCESSIBILITY_PLATFORM_AX_PLATFORM_NODE_DELEGATE_H_ 6 #define UI_ACCESSIBILITY_PLATFORM_AX_PLATFORM_NODE_DELEGATE_H_
7 7
8 #include "ui/accessibility/ax_enums.h" 8 #include "ui/accessibility/ax_enums.h"
9 #include "ui/accessibility/ax_export.h" 9 #include "ui/accessibility/ax_export.h"
10 #include "ui/gfx/geometry/vector2d.h" 10 #include "ui/gfx/geometry/vector2d.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 78
79 // 79 //
80 // Actions. 80 // Actions.
81 // 81 //
82 82
83 // Perform the default action, e.g. click a button, follow a link, or 83 // Perform the default action, e.g. click a button, follow a link, or
84 // toggle a checkbox. 84 // toggle a checkbox.
85 virtual void DoDefaultAction() = 0; 85 virtual void DoDefaultAction() = 0;
86 86
87 // Change the value of a control, such as the text content of a text field. 87 // Change the value of a control, such as the text content of a text field.
88 virtual bool SetStringValue(const base::string16& new_value) = 0; 88 // Optionally replace it or insert at the cursor if |replace| is true.
dmazzoni 2016/10/25 17:21:49 Same here, flip the boolean around and rename it s
Patti Lor 2016/10/26 00:57:15 Done.
89 virtual bool SetStringValue(const base::string16& new_value,
90 bool replace) = 0;
89 91
90 // Whether the string value is settable. 92 // Whether SetStringValue() and ReplaceSelectedText() are callable, i.e. if
93 // the string value is read only and if the callback exists.
91 virtual bool CanSetStringValue() = 0; 94 virtual bool CanSetStringValue() = 0;
92 }; 95 };
93 96
94 } // namespace ui 97 } // namespace ui
95 98
96 #endif // UI_ACCESSIBILITY_PLATFORM_AX_PLATFORM_NODE_DELEGATE_H_ 99 #endif // UI_ACCESSIBILITY_PLATFORM_AX_PLATFORM_NODE_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698