Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: ui/accessibility/ax_view_state.h

Issue 2341633006: MacViews/a11y: Allow accessibility clients to update the selected text. (Closed)
Patch Set: Make set value callbacks not have a const bool |replace| arg. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/accessibility/ax_view_state.h
diff --git a/ui/accessibility/ax_view_state.h b/ui/accessibility/ax_view_state.h
index a20a65d6e7d41190cf9562522913e6b535b8c0e7..f403d00b7af3d1adc78343cd7bd85a56b06d2ca5 100644
--- a/ui/accessibility/ax_view_state.h
+++ b/ui/accessibility/ax_view_state.h
@@ -75,12 +75,13 @@ struct AX_EXPORT AXViewState {
// set the string value of this view. This only applies to roles where
// setting the value makes sense, like a text box. Not often used by
// screen readers, but often used by automation software to script
- // things like logging into portals or filling forms.
+ // things like logging into portals or filling forms. Set the second argument
+ // to insert at the cursor or replace the currently selected text.
//
// This callback is only valid for the lifetime of the view, and should
// be a safe no-op if the view is deleted. Typically, accessible views
// should use a WeakPtr when binding the callback.
- base::Callback<void(const base::string16&)> set_value_callback;
+ base::Callback<void(const base::string16&, bool)> set_value_callback;
dmazzoni 2016/10/25 17:21:49 Maybe the same here, the bool could be replace all
Patti Lor 2016/10/26 00:57:15 Ah, thanks for the FYI - will definitely be needin
private:
uint32_t state_;

Powered by Google App Engine
This is Rietveld 408576698