third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp - Issue 2341333003: Use chromium trace_event implementation in blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

Issue 2341333003: Use chromium trace_event implementation in blink (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp ('k') | third_party/WebKit/Source/core/paint/PaintTiming.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

diff --git a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

index 8591e50084c2883ad1cc5f3b0a2049e6ae1c21da..2d7c7007f9007dd6e8a341731ec5c5858fb30220 100644

--- a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

+++ b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

@@ -88,7 +88,7 @@ void FirstMeaningfulPaintDetector::notifyPaint()

m_provisionalFirstMeaningfulPaint = monotonicallyIncreasingTime();

m_state = NextPaintIsNotMeaningful;

- TRACE_EVENT_MARK_WITH_TIMESTAMP1("loading", "firstMeaningfulPaintCandidate", m_provisionalFirstMeaningfulPaint, "frame", document()->frame());

+ TRACE_EVENT_MARK_WITH_TIMESTAMP1("loading", "firstMeaningfulPaintCandidate", TraceEvent::toTraceTimestamp(m_provisionalFirstMeaningfulPaint), "frame", document()->frame());

}

void FirstMeaningfulPaintDetector::checkNetworkStable()