third_party/WebKit/Source/core/paint/PaintTiming.cpp - Issue 2341333003: Use chromium trace_event implementation in blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintTiming.cpp

Issue 2341333003: Use chromium trace_event implementation in blink (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp ('k') | third_party/WebKit/Source/core/timing/PerformanceUserTiming.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintTiming.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintTiming.cpp b/third_party/WebKit/Source/core/paint/PaintTiming.cpp

index c23493ca5a154bf53853fa2e10920a6f560c3a30..1004a09650f05630590d8d9de957a64076f01d2d 100644

--- a/third_party/WebKit/Source/core/paint/PaintTiming.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintTiming.cpp

@@ -51,7 +51,7 @@ void PaintTiming::markFirstTextPaint()

return;

m_firstTextPaint = monotonicallyIncreasingTime();

setFirstContentfulPaint(m_firstTextPaint);

- TRACE_EVENT_MARK_WITH_TIMESTAMP1("blink.user_timing,rail", "firstTextPaint", m_firstTextPaint, "frame", frame());

+ TRACE_EVENT_MARK_WITH_TIMESTAMP1("blink.user_timing,rail", "firstTextPaint", TraceEvent::toTraceTimestamp(m_firstTextPaint), "frame", frame());

notifyPaintTimingChanged();

}

@@ -61,7 +61,7 @@ void PaintTiming::markFirstImagePaint()

return;

m_firstImagePaint = monotonicallyIncreasingTime();

setFirstContentfulPaint(m_firstImagePaint);

- TRACE_EVENT_MARK_WITH_TIMESTAMP1("blink.user_timing,rail", "firstImagePaint", m_firstImagePaint, "frame", frame());

+ TRACE_EVENT_MARK_WITH_TIMESTAMP1("blink.user_timing,rail", "firstImagePaint", TraceEvent::toTraceTimestamp(m_firstImagePaint), "frame", frame());

notifyPaintTimingChanged();

}

@@ -69,7 +69,7 @@ void PaintTiming::setFirstMeaningfulPaint(double stamp)

{

DCHECK_EQ(m_firstMeaningfulPaint, 0.0);

m_firstMeaningfulPaint = stamp;

- TRACE_EVENT_MARK_WITH_TIMESTAMP1("blink.user_timing", "firstMeaningfulPaint", m_firstMeaningfulPaint, "frame", frame());

+ TRACE_EVENT_MARK_WITH_TIMESTAMP1("blink.user_timing", "firstMeaningfulPaint", TraceEvent::toTraceTimestamp(m_firstMeaningfulPaint), "frame", frame());

notifyPaintTimingChanged();

}