third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp - Issue 2341053002: Mark the createVisiblePosition overloads as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)

Patch Set: minor revision Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp ('K') | « third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | third_party/WebKit/Source/core/layout/HitTestResult.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp

diff --git a/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp b/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp

index 0ac1e649df0bbd233217c7741f0c2ed9c84fb6d4..44f0de90f48be206c2bf8b790ac7f5fc9f856411 100644

--- a/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp

+++ b/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp

@@ -173,8 +173,8 @@ String StyledMarkupSerializer<Strategy>::createMarkup()

Node* pastEnd = m_end.nodeAsRangePastLastNode();

Node* firstNode = m_start.nodeAsRangeFirstNode();

- const VisiblePositionTemplate<Strategy> visibleStart = createVisiblePosition(m_start);

- const VisiblePositionTemplate<Strategy> visibleEnd = createVisiblePosition(m_end);

+ const VisiblePositionTemplate<Strategy> visibleStart = createVisiblePositionDeprecated(m_start);

+ const VisiblePositionTemplate<Strategy> visibleEnd = createVisiblePositionDeprecated(m_end);

if (shouldAnnotate() && needInterchangeNewlineAfter(visibleStart)) {

markupAccumulator.appendInterchangeNewline();

if (visibleStart.deepEquivalent() == previousPositionOf(visibleEnd).deepEquivalent())