Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)
Patch Set: minor revision Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
index 65499eb9ef60fe2ad99d7dc84340b1c19243934d..a702f6088b141924fe3d03b3c7f43e0792d47575 100644
--- a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
@@ -169,7 +169,7 @@ void InsertTextCommand::doApply(EditingState* editingState)
Position downstream(mostForwardCaretPosition(startPosition));
if (lineBreakExistsAtPosition(downstream)) {
// FIXME: This doesn't handle placeholders at the end of anonymous blocks.
- VisiblePosition caret = createVisiblePosition(startPosition);
+ VisiblePosition caret = createVisiblePositionDeprecated(startPosition);
if (isEndOfBlock(caret) && isStartOfParagraph(caret))
placeholder = downstream;
// Don't remove the placeholder yet, otherwise the block we're inserting into would collapse before
@@ -250,7 +250,7 @@ void InsertTextCommand::doApply(EditingState* editingState)
Position InsertTextCommand::insertTab(const Position& pos, EditingState* editingState)
{
- Position insertPos = createVisiblePosition(pos).deepEquivalent();
+ Position insertPos = createVisiblePositionDeprecated(pos).deepEquivalent();
if (insertPos.isNull())
return pos;

Powered by Google App Engine
This is Rietveld 408576698