third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp - Issue 2341053002: Mark the createVisiblePosition overloads as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)

Patch Set: minor revision Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp » ('j') | third_party/WebKit/Source/core/layout/HitTestResult.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

index fcffe7074990422e9f9fe5e7abe3867484fd8851..91e25fc68f4c58e7ae8d798e945d5c9b3930f34f 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

@@ -256,8 +256,8 @@ void ApplyStyleCommand::applyBlockStyle(EditingStyle *style, EditingState* editi

end = swap;

}

- VisiblePosition visibleStart = createVisiblePosition(start);

- VisiblePosition visibleEnd = createVisiblePosition(end);

+ VisiblePosition visibleStart = createVisiblePositionDeprecated(start);

+ VisiblePosition visibleEnd = createVisiblePositionDeprecated(end);

if (visibleStart.isNull() || visibleStart.isOrphan() || visibleEnd.isNull() || visibleEnd.isOrphan())

return;

@@ -287,7 +287,7 @@ void ApplyStyleCommand::applyBlockStyle(EditingStyle *style, EditingState* editi

if (newBlock) {

block = newBlock;

if (paragraphStart.isOrphan())

- paragraphStart = createVisiblePosition(Position::firstPositionInNode(newBlock));

+ paragraphStart = createVisiblePositionDeprecated(Position::firstPositionInNode(newBlock));

}

DCHECK(!paragraphStart.isOrphan()) << paragraphStart;

}