third_party/WebKit/Source/core/editing/VisibleSelection.h - Issue 2341053002: Mark the createVisiblePosition overloads as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)

Patch Set: minor revision Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp ('K') | « third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp ('k') | third_party/WebKit/Source/core/editing/VisibleSelection.cpp » ('j') | third_party/WebKit/Source/core/layout/HitTestResult.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/VisibleSelection.h

diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h

index d1fb4ffa8bb24ab6b71622900bab95980149ebeb..8656c59c98cb8f3e3901d1f7b546ab8ecb7cfd2c 100644

--- a/third_party/WebKit/Source/core/editing/VisibleSelection.h

+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h

@@ -78,10 +78,10 @@ public:

PositionTemplate<Strategy> start() const { return m_start; }

PositionTemplate<Strategy> end() const { return m_end; }

- VisiblePositionTemplate<Strategy> visibleStart() const { return createVisiblePosition(m_start, isRange() ? TextAffinity::Downstream : affinity()); }

- VisiblePositionTemplate<Strategy> visibleEnd() const { return createVisiblePosition(m_end, isRange() ? TextAffinity::Upstream : affinity()); }

- VisiblePositionTemplate<Strategy> visibleBase() const { return createVisiblePosition(m_base, isRange() ? (isBaseFirst() ? TextAffinity::Upstream : TextAffinity::Downstream) : affinity()); }

- VisiblePositionTemplate<Strategy> visibleExtent() const { return createVisiblePosition(m_extent, isRange() ? (isBaseFirst() ? TextAffinity::Downstream : TextAffinity::Upstream) : affinity()); }

+ VisiblePositionTemplate<Strategy> visibleStart() const { return createVisiblePositionDeprecated(m_start, isRange() ? TextAffinity::Downstream : affinity()); }

+ VisiblePositionTemplate<Strategy> visibleEnd() const { return createVisiblePositionDeprecated(m_end, isRange() ? TextAffinity::Upstream : affinity()); }

+ VisiblePositionTemplate<Strategy> visibleBase() const { return createVisiblePositionDeprecated(m_base, isRange() ? (isBaseFirst() ? TextAffinity::Upstream : TextAffinity::Downstream) : affinity()); }

+ VisiblePositionTemplate<Strategy> visibleExtent() const { return createVisiblePositionDeprecated(m_extent, isRange() ? (isBaseFirst() ? TextAffinity::Downstream : TextAffinity::Upstream) : affinity()); }

bool operator==(const VisibleSelectionTemplate&) const;

bool operator!=(const VisibleSelectionTemplate& other) const { return !operator==(other); }