Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)
Patch Set: minor revision Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionController.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp
index 886b88e786b5fe28a6e7a7c9ca76d9f092528c68..c51b8611dadfb7e804e58b0b952b734d5a35bfaa 100644
--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp
@@ -114,7 +114,7 @@ bool canMouseDownStartSelect(Node* node)
VisiblePositionInFlatTree visiblePositionOfHitTestResult(const HitTestResult& hitTestResult)
{
- return createVisiblePosition(
+ return createVisiblePositionDeprecated(
fromPositionInDOMTree<EditingInFlatTreeStrategy>(hitTestResult.innerNode()->layoutObject()->positionForPoint(hitTestResult.localPoint())));
}
@@ -144,14 +144,14 @@ bool SelectionController::handleMousePressEventSingleClick(const MouseEventWithH
VisiblePositionInFlatTree visiblePos = visiblePositionOfHitTestResult(event.hitTestResult());
if (visiblePos.isNull())
- visiblePos = createVisiblePosition(PositionInFlatTree::firstPositionInOrBeforeNode(innerNode));
+ visiblePos = createVisiblePositionDeprecated(PositionInFlatTree::firstPositionInOrBeforeNode(innerNode));
PositionInFlatTree pos = visiblePos.deepEquivalent();
VisibleSelectionInFlatTree newSelection = selection().visibleSelection<EditingInFlatTreeStrategy>();
TextGranularity granularity = CharacterGranularity;
if (extendSelection && !newSelection.isNone()) {
- const VisibleSelectionInFlatTree selectionInUserSelectAll(expandSelectionToRespectUserSelectAll(innerNode, VisibleSelectionInFlatTree(createVisiblePosition(pos))));
+ const VisibleSelectionInFlatTree selectionInUserSelectAll(expandSelectionToRespectUserSelectAll(innerNode, VisibleSelectionInFlatTree(createVisiblePositionDeprecated(pos))));
if (selectionInUserSelectAll.isRange()) {
if (selectionInUserSelectAll.start().compareTo(newSelection.start()) < 0)
pos = selectionInUserSelectAll.start();
@@ -199,7 +199,7 @@ void SelectionController::updateSelectionForMouseDrag(const HitTestResult& hitTe
return;
const PositionWithAffinity& rawTargetPosition = positionRespectingEditingBoundary(selection().selection().start(), hitTestResult.localPoint(), target);
- VisiblePositionInFlatTree targetPosition = createVisiblePosition(fromPositionInDOMTree<EditingInFlatTreeStrategy>(rawTargetPosition));
+ VisiblePositionInFlatTree targetPosition = createVisiblePositionDeprecated(fromPositionInDOMTree<EditingInFlatTreeStrategy>(rawTargetPosition));
// Don't modify the selection if we're not on a node.
if (targetPosition.isNull())
return;

Powered by Google App Engine
This is Rietveld 408576698