Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: third_party/WebKit/Source/core/editing/FrameCaret.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)
Patch Set: minor revision Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameCaret.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameCaret.cpp b/third_party/WebKit/Source/core/editing/FrameCaret.cpp
index 0ea6c49f75bd452ff826c3bf37ee5627a9576456..f4f1fa8f13448423957832404771e8fbac4323d9 100644
--- a/third_party/WebKit/Source/core/editing/FrameCaret.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameCaret.cpp
@@ -81,7 +81,7 @@ void FrameCaret::updateAppearance()
{
// Paint a block cursor instead of a caret in overtype mode unless the caret is at the end of a line (in this case
// the FrameSelection will paint a blinking caret as usual).
- bool paintBlockCursor = m_shouldShowBlockCursor && isActive() && !isLogicalEndOfLine(createVisiblePosition(caretPosition()));
+ bool paintBlockCursor = m_shouldShowBlockCursor && isActive() && !isLogicalEndOfLine(createVisiblePositionDeprecated(caretPosition()));
bool shouldBlink = !paintBlockCursor && shouldBlinkCaret();
@@ -196,9 +196,9 @@ IntRect FrameCaret::absoluteCaretBounds()
if (isVisuallyEquivalentCandidate(caretPosition().position()))
updateCaretRect(caretPosition());
else
- updateCaretRect(createVisiblePosition(caretPosition()));
+ updateCaretRect(createVisiblePositionDeprecated(caretPosition()));
} else {
- updateCaretRect(createVisiblePosition(caretPosition()));
+ updateCaretRect(createVisiblePositionDeprecated(caretPosition()));
}
}
return absoluteBoundsForLocalRect(caretPosition().position().anchorNode(), localCaretRectWithoutUpdate());

Powered by Google App Engine
This is Rietveld 408576698