third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp - Issue 2341053002: Mark the createVisiblePosition overloads as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)

Patch Set: minor revision Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

index b0d3d8ed7f65b5630e87c2064476944cdb5c1463..d939ec25719f5698f753278bf55d40d8a8c931c7 100644

--- a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

@@ -106,16 +106,16 @@ TEST_F(EditingUtilitiesTest, tableElementJustBefore)

EXPECT_EQ(table, tableElementJustBefore(VisiblePositionInFlatTree::afterNode(table)));

EXPECT_EQ(table, tableElementJustBefore(VisiblePosition::lastPositionInNode(table)));

- EXPECT_EQ(table, tableElementJustBefore(createVisiblePosition(PositionInFlatTree::lastPositionInNode(table))));

+ EXPECT_EQ(table, tableElementJustBefore(createVisiblePositionDeprecated(PositionInFlatTree::lastPositionInNode(table))));

- EXPECT_EQ(nullptr, tableElementJustBefore(createVisiblePosition(Position(host, 2))));

- EXPECT_EQ(table, tableElementJustBefore(createVisiblePosition(PositionInFlatTree(host, 2))));

+ EXPECT_EQ(nullptr, tableElementJustBefore(createVisiblePositionDeprecated(Position(host, 2))));

+ EXPECT_EQ(table, tableElementJustBefore(createVisiblePositionDeprecated(PositionInFlatTree(host, 2))));

EXPECT_EQ(nullptr, tableElementJustBefore(VisiblePosition::afterNode(host)));

EXPECT_EQ(nullptr, tableElementJustBefore(VisiblePositionInFlatTree::afterNode(host)));

EXPECT_EQ(nullptr, tableElementJustBefore(VisiblePosition::lastPositionInNode(host)));

- EXPECT_EQ(table, tableElementJustBefore(createVisiblePosition(PositionInFlatTree::lastPositionInNode(host))));

+ EXPECT_EQ(table, tableElementJustBefore(createVisiblePositionDeprecated(PositionInFlatTree::lastPositionInNode(host))));

}

TEST_F(EditingUtilitiesTest, lastEditablePositionBeforePositionInRoot)