third_party/WebKit/Source/core/editing/DragCaretController.cpp - Issue 2341053002: Mark the createVisiblePosition overloads as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/DragCaretController.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)

Patch Set: minor revision Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/DragCaretController.cpp

diff --git a/third_party/WebKit/Source/core/editing/DragCaretController.cpp b/third_party/WebKit/Source/core/editing/DragCaretController.cpp

index abaed388c6ad74d1c5c7aceabbb39b6bfb4a7e92..947bb1925fb5ad846e7e983494137f5b6cddf834 100644

--- a/third_party/WebKit/Source/core/editing/DragCaretController.cpp

+++ b/third_party/WebKit/Source/core/editing/DragCaretController.cpp

@@ -69,7 +69,7 @@ void DragCaretController::setCaretPosition(const PositionWithAffinity& position)

if (Node* node = m_position.deepEquivalent().anchorNode())

m_caretBase->invalidateCaretRect(node);

- m_position = createVisiblePosition(position);

+ m_position = createVisiblePositionDeprecated(position);

Document* document = nullptr;

if (Node* node = m_position.deepEquivalent().anchorNode()) {

m_caretBase->invalidateCaretRect(node);