Tweaks to "Allow InkDropRipple to co-exist with highlight or not exist at all."

Tweaks to "Allow InkDropRipple to co-exist with highlight or not exist at all."

1. Allow InkDropRipple to co-exist with highlight by adding
InkDropRipple::OverridesHighlight. I initially made this part of
InkDropHost but then realized that it was more a property of the ripple
itself, and it would be too easy to overlook when adding an ink drop to
a new surface.

2. Allow InkDropRipple to not exist but still retain an InkDropHighlight.
This is desired for a couple menu-like UI surfaces in secondary UI. This
is effected with an EmptyInkDropRipple class that just no-ops while allowing
the hover effect to remain.

The immediate effect of this change is that flood fill ripples will paint
on top of the hover highlight effect (e.g. on bookmark buttons).

BUG=617961
patch from issue 2250783002 at patchset 160001 (http://crrev.com/2250783002#ps160001)

[bruthig, 2016-09-15 04:57:44]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 04:57:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 05:01:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 05:01:20]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[bruthig, 2016-09-15 05:06:42]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 05:06:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 05:40:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 05:40:15]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[bruthig, 2016-09-15 14:17:52]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 14:18:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 16:10:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 16:11:00]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-09-20 15:16:29]

estade@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2016-09-20 15:16:29]

thanks for posting this

https://codereview.chromium.org/2340993002/diff/60001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_ripple.cc (right):

https://codereview.chromium.org/2340993002/diff/60001/ui/views/animation/ink_...
ui/views/animation/ink_drop_ripple.cc:45: ui::CallbackLayerAnimationObserver*
animation_observer =
what happens to animation_observer when !GetRootLayer()?

[bruthig, 2016-09-20 16:17:16]

https://codereview.chromium.org/2340993002/diff/60001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_ripple.cc (right):

https://codereview.chromium.org/2340993002/diff/60001/ui/views/animation/ink_...
ui/views/animation/ink_drop_ripple.cc:45: ui::CallbackLayerAnimationObserver*
animation_observer =
On 2016/09/20 15:16:29, Evan Stade wrote:
> what happens to animation_observer when !GetRootLayer()?

A test would be the best way to know for sure, but I'm expecting the
|animation_observer| doesn't get any LayerAnimations added to it and when
SetActive() is called on line 67 it will invoke the callbacks synchronously.