ui/views/animation/square_ink_drop_ripple.h - Issue 2340993002: Tweaks to "Allow InkDropRipple to co-exist with highlight or not exist at all."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/animation/square_ink_drop_ripple.h

Issue 2340993002: Tweaks to "Allow InkDropRipple to co-exist with highlight or not exist at all." (Closed)

Patch Set: Fixed InkDropImplTest.HighlightCanExistWithoutRipple. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/animation/square_ink_drop_ripple.h

diff --git a/ui/views/animation/square_ink_drop_ripple.h b/ui/views/animation/square_ink_drop_ripple.h

index 059d8395e4532c087c9e9b2bf2696f62704e505b..293d46a03e9b793c3ea3ebfbe4f153493e68a3c0 100644

--- a/ui/views/animation/square_ink_drop_ripple.h

+++ b/ui/views/animation/square_ink_drop_ripple.h

@@ -67,7 +67,7 @@ class VIEWS_EXPORT SquareInkDropRipple : public InkDropRipple {

// InkDropRipple:

void SnapToActivated() override;

ui::Layer* GetRootLayer() override;

- bool IsVisible() const override;

+ bool OverridesHighlight() const override;

private:

friend class test::SquareInkDropRippleTestApi;