Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: ui/views/animation/ink_drop_ripple.h

Issue 2340993002: Tweaks to "Allow InkDropRipple to co-exist with highlight or not exist at all." (Closed)
Patch Set: Fixed InkDropImplTest.HighlightCanExistWithoutRipple. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/animation/ink_drop_ripple.h
diff --git a/ui/views/animation/ink_drop_ripple.h b/ui/views/animation/ink_drop_ripple.h
index efc4972e9040992c7def572186e7d42ca244ac17..49672d5b857feae54dce488633a2724c2bf66f7f 100644
--- a/ui/views/animation/ink_drop_ripple.h
+++ b/ui/views/animation/ink_drop_ripple.h
@@ -72,13 +72,16 @@ class VIEWS_EXPORT InkDropRipple {
// as well as the transition to the ACTIVATED state.
virtual void SnapToActivated();
- // The root Layer that can be added in to a Layer tree.
+ // The root Layer that can be added in to a Layer tree. This may return null.
virtual ui::Layer* GetRootLayer() = 0;
// Returns true when the ripple is visible. This is different from checking if
// the ink_drop_state() == HIDDEN because the ripple may be visible while it
// animates to the target HIDDEN state.
- virtual bool IsVisible() const = 0;
+ bool IsVisible();
+
+ // Returns true if this ripple is mutually exclusive with InkDropHighlight.
+ virtual bool OverridesHighlight() const = 0;
// Returns a test api to access internals of this. Default implmentations
// should return nullptr and test specific subclasses can override to return

Powered by Google App Engine
This is Rietveld 408576698