Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2340813004: Revert "Use checked-in .package file for building and testing" (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 3 months ago
Reviewers:
eernst
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Use checked-in .package file for building and testing" This reverts commit 5d3e356ca75be8aeff3efde5df946d746b9f8352. BUG= R=eernst@google.com Committed: https://github.com/dart-lang/sdk/commit/6d238ba197c8bda71afe790f16f6e9adaf7abd13

Patch Set 1 #

Patch Set 2 : Fix more test and build failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -246 lines) Patch
M .gitignore View 1 1 chunk +0 lines, -1 line 0 comments Download
A .packages View 1 1 chunk +103 lines, -0 lines 0 comments Download
M pkg/pkg.gyp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/dart-runtime.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/observatory.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/bin/dart2js View 1 1 chunk +1 line, -38 lines 0 comments Download
M sdk/bin/dart2js.bat View 1 1 chunk +1 line, -8 lines 0 comments Download
M sdk/bin/dartanalyzer View 1 1 chunk +1 line, -39 lines 0 comments Download
M sdk/bin/dartanalyzer.bat View 1 1 chunk +1 line, -8 lines 0 comments Download
M sdk/bin/dartdevc View 1 1 chunk +1 line, -39 lines 0 comments Download
M sdk/bin/dartdevc.bat View 1 1 chunk +1 line, -8 lines 0 comments Download
M sdk/bin/dartfmt View 1 1 chunk +1 line, -14 lines 0 comments Download
M sdk/bin/dartfmt.bat View 1 1 chunk +1 line, -8 lines 0 comments Download
M sdk/bin/pub View 1 1 chunk +1 line, -2 lines 0 comments Download
M sdk/bin/pub.bat View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/addlatexhash_test.dart View 1 3 chunks +16 lines, -6 lines 0 comments Download
M tests/standalone/io/code_collection_test.dart View 1 1 chunk +12 lines, -3 lines 0 comments Download
M tests/standalone/io/http_client_stays_alive_test.dart View 1 2 chunks +12 lines, -4 lines 0 comments Download
M tests/standalone/io/platform_test.dart View 1 2 chunks +7 lines, -6 lines 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 2 chunks +13 lines, -1 line 0 comments Download
M tools/bots/dart_sdk.py View 1 1 chunk +1 line, -4 lines 0 comments Download
M tools/make_links.py View 1 5 chunks +34 lines, -11 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 7 chunks +14 lines, -13 lines 0 comments Download
M utils/analysis_server/analysis_server.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M utils/compiler/compiler.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M utils/compiler/create_snapshot.dart View 1 4 chunks +5 lines, -9 lines 0 comments Download
M utils/dartanalyzer/dartanalyzer.gyp View 1 5 chunks +0 lines, -5 lines 0 comments Download
M utils/dartdevc/dartdevc.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M utils/dartdoc/dartdoc.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M utils/dartfmt/dartfmt.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M utils/pub/pub.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
4 years, 3 months ago (2016-09-15 13:37:38 UTC) #1
eernst
lgtm
4 years, 3 months ago (2016-09-15 13:46:35 UTC) #2
Bill Hesse
4 years, 3 months ago (2016-09-15 13:46:56 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6d238ba197c8bda71afe790f16f6e9adaf7abd13 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698