Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: tests/standalone/io/platform_test.dart

Issue 2340813004: Revert "Use checked-in .package file for building and testing" (Closed)
Patch Set: Fix more test and build failures Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/http_client_stays_alive_test.dart ('k') | tests/standalone/io/test_runner_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/platform_test.dart
diff --git a/tests/standalone/io/platform_test.dart b/tests/standalone/io/platform_test.dart
index 308d5d013c01df9f3f2ce91a8014d4ebfcd65868..dd8defda58db0d6b4329a5af6e64be0af442cea3 100644
--- a/tests/standalone/io/platform_test.dart
+++ b/tests/standalone/io/platform_test.dart
@@ -49,10 +49,11 @@ test() {
// Restore dir.
Directory.current = oldDir;
var pkgRootString = Platform.packageRoot;
- Directory packageRoot = new Directory.fromUri(Uri.parse(pkgRootString));
- Expect.isTrue(packageRoot.existsSync());
- Expect.isTrue(new Directory("${packageRoot.path}/expect").existsSync());
- Expect.isTrue(Platform.executableArguments.any(
+ if (pkgRootString != null) {
+ Directory packageRoot = new Directory.fromUri(Uri.parse(pkgRootString));
+ Expect.isTrue(packageRoot.existsSync());
+ Expect.isTrue(new Directory("${packageRoot.path}/expect").existsSync());
+ Expect.isTrue(Platform.executableArguments.any(
(arg) {
if (!arg.startsWith("--package-root=")) {
return false;
@@ -60,8 +61,8 @@ test() {
// Cut out the '--package-root=' prefix.
arg = arg.substring(15);
return pkgRootString.contains(arg);
- }
- ));
+ }));
+ }
}
void f(reply) {
« no previous file with comments | « tests/standalone/io/http_client_stays_alive_test.dart ('k') | tests/standalone/io/test_runner_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698