Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: tests/standalone/io/code_collection_test.dart

Issue 2340813004: Revert "Use checked-in .package file for building and testing" (Closed)
Patch Set: Fix more test and build failures Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/addlatexhash_test.dart ('k') | tests/standalone/io/http_client_stays_alive_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/code_collection_test.dart
diff --git a/tests/standalone/io/code_collection_test.dart b/tests/standalone/io/code_collection_test.dart
index 374739979d9e295529a03668afa8e680a2aaebae..e9ebb0f081566178b304540665641dda70879314 100644
--- a/tests/standalone/io/code_collection_test.dart
+++ b/tests/standalone/io/code_collection_test.dart
@@ -44,22 +44,31 @@ doTest() {
});
}
+List<String> packageOptions() {
+ if (Platform.packageRoot != null) {
+ return <String>['--package-root=${Platform.packageRoot}'];
+ } else if (Platform.packageConfig != null) {
+ return <String>['--packages=${Platform.packageConfig}'];
+ } else {
+ return <String>[];
+ }
+}
main(List<String> arguments) {
if (arguments.contains("--run")) {
doTest();
} else {
// Run the test and capture stdout.
- var pr = Process.runSync(Platform.executable,
- ["--verbose-gc",
+ var args = packageOptions();
+ args.addAll(["--verbose-gc",
"--collect-code",
"--code-collection-interval-in-us=0",
"--old_gen_growth_rate=10",
"--log-code-drop",
"--optimization-counter-threshold=-1",
- "--package-root=${Platform.packageRoot}",
Platform.script.toFilePath(),
"--run"]);
+ var pr = Process.runSync(Platform.executable, args);
Expect.equals(0, pr.exitCode);
« no previous file with comments | « tests/standalone/io/addlatexhash_test.dart ('k') | tests/standalone/io/http_client_stays_alive_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698