Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2340603003: Remove "f" suffix from literal in LCD DF text shader. (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove "f" suffix from literal in LCD DF text shader. Also improve DF GP names GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340603003 Committed: https://skia.googlesource.com/skia/+/32d1e95ca593adfaa12bc48d4ac0d5501a4b2046

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/gpu/effects/GrDistanceFieldGeoProc.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
bsalomon
4 years, 3 months ago (2016-09-14 16:04:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340603003/1
4 years, 3 months ago (2016-09-14 16:04:23 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-14 16:04:24 UTC) #6
jvanverth1
https://codereview.chromium.org/2340603003/diff/1/src/gpu/effects/GrDistanceFieldGeoProc.h File src/gpu/effects/GrDistanceFieldGeoProc.h (right): https://codereview.chromium.org/2340603003/diff/1/src/gpu/effects/GrDistanceFieldGeoProc.h#newcode132 src/gpu/effects/GrDistanceFieldGeoProc.h:132: const char* name() const override { return "DistanceFieldText"; } ...
4 years, 3 months ago (2016-09-14 20:11:06 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
4 years, 3 months ago (2016-09-14 22:04:17 UTC) #9
bsalomon
https://codereview.chromium.org/2340603003/diff/1/src/gpu/effects/GrDistanceFieldGeoProc.h File src/gpu/effects/GrDistanceFieldGeoProc.h (right): https://codereview.chromium.org/2340603003/diff/1/src/gpu/effects/GrDistanceFieldGeoProc.h#newcode132 src/gpu/effects/GrDistanceFieldGeoProc.h:132: const char* name() const override { return "DistanceFieldText"; } ...
4 years, 3 months ago (2016-09-15 13:59:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340603003/20001
4 years, 3 months ago (2016-09-15 14:00:08 UTC) #12
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-15 14:00:09 UTC) #13
jvanverth1
lgtm
4 years, 3 months ago (2016-09-15 14:00:57 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 14:29:54 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/32d1e95ca593adfaa12bc48d4ac0d5501a4b2046

Powered by Google App Engine
This is Rietveld 408576698