Fix FontFaceSet state getting stuck at loading

Fix FontFaceSet state getting stuck at loading

This fixes a bug where the status attribute of FontFaceSet gets stuck
at "loading" when @font-face rule is removed while the font is loading.

Before this patch, font load completion was notified from
CSSFontFace::setLoadStatus() via m_segmentedFontFace, but if the
@font-face rule is detached, m_segmentedFontFace is null.
After this patch, FontFaceSet registers itself as an observer of
FontFace for load completion.

BUG=641322
Committed: https://crrev.com/035a2a978b7ec4f87439c355af25941fb0b9cfca
Cr-Commit-Position: refs/heads/master@{#421114}

[Kunihiko Sakamoto, 2016-09-15 06:04:35]

The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 06:04:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 07:29:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 07:29:58]

Dry run: This issue passed the CQ dry run.

[Kunihiko Sakamoto, 2016-09-15 09:03:22]

The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 09:03:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 09:13:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 09:13:19]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Kunihiko Sakamoto, 2016-09-15 09:22:19]

The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 09:22:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kunihiko Sakamoto, 2016-09-15 09:24:44]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-09-15 10:45:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 10:45:51]

Dry run: This issue passed the CQ dry run.

[Kunihiko Sakamoto, 2016-09-16 02:25:43]

Patchset #1 (id:1) has been deleted

[Kunihiko Sakamoto, 2016-09-16 02:26:13]

Description was changed from

==========
WIP
==========

to

==========
Fix FontFaceSet state getting stuck at loading

This fixes a bug where the status attribute of FontFaceSet gets stuck
at "loading" when @font-face rule is removed while the font is loading.

Font load completion was notified from CSSFontFace::setLoadStatus()
via m_segmentedFontFace, but m_segmentedFontFace is null if the
@font-face rule is detached. After this patch, FontFaceSet registers
itself as an observer of FontFace for load completion.

BUG=641322
==========

[Kunihiko Sakamoto, 2016-09-16 02:27:32]

Description was changed from

==========
Fix FontFaceSet state getting stuck at loading

This fixes a bug where the status attribute of FontFaceSet gets stuck
at "loading" when @font-face rule is removed while the font is loading.

Font load completion was notified from CSSFontFace::setLoadStatus()
via m_segmentedFontFace, but m_segmentedFontFace is null if the
@font-face rule is detached. After this patch, FontFaceSet registers
itself as an observer of FontFace for load completion.

BUG=641322
==========

to

==========
Fix FontFaceSet state getting stuck at loading

This fixes a bug where the status attribute of FontFaceSet gets stuck
at "loading" when @font-face rule is removed while the font is loading.

Before this patch, font load completion was notified from
CSSFontFace::setLoadStatus() via m_segmentedFontFace, but
m_segmentedFontFace is null if the @font-face rule is detached.
After this patch, FontFaceSet registers itself as an observer of
FontFace for load completion.

BUG=641322
==========

[Kunihiko Sakamoto, 2016-09-16 02:28:14]

Description was changed from

==========
Fix FontFaceSet state getting stuck at loading

This fixes a bug where the status attribute of FontFaceSet gets stuck
at "loading" when @font-face rule is removed while the font is loading.

Before this patch, font load completion was notified from
CSSFontFace::setLoadStatus() via m_segmentedFontFace, but
m_segmentedFontFace is null if the @font-face rule is detached.
After this patch, FontFaceSet registers itself as an observer of
FontFace for load completion.

BUG=641322
==========

to

==========
Fix FontFaceSet state getting stuck at loading

This fixes a bug where the status attribute of FontFaceSet gets stuck
at "loading" when @font-face rule is removed while the font is loading.

Before this patch, font load completion was notified from
CSSFontFace::setLoadStatus() via m_segmentedFontFace, but if the
@font-face rule is detached m_segmentedFontFace is null.
After this patch, FontFaceSet registers itself as an observer of
FontFace for load completion.

BUG=641322
==========

[Kunihiko Sakamoto, 2016-09-16 02:30:19]

ksakamoto@chromium.org changed reviewers:
+ toyoshim@chromium.org

[Kunihiko Sakamoto, 2016-09-16 02:30:20]

Toyoshima-san, PTAL?

[Takashi Toyoshima, 2016-09-16 05:07:00]

In the CL description,
> @font-face rule is detached m_segmentedFontFace is null.

Does this mean "... was detached, m_segmentedFontFace is null here"?
Probably, inserting "," makes easy to understand this line.

[Kunihiko Sakamoto, 2016-09-16 05:38:54]

Description was changed from

==========
Fix FontFaceSet state getting stuck at loading

This fixes a bug where the status attribute of FontFaceSet gets stuck
at "loading" when @font-face rule is removed while the font is loading.

Before this patch, font load completion was notified from
CSSFontFace::setLoadStatus() via m_segmentedFontFace, but if the
@font-face rule is detached m_segmentedFontFace is null.
After this patch, FontFaceSet registers itself as an observer of
FontFace for load completion.

BUG=641322
==========

to

==========
Fix FontFaceSet state getting stuck at loading

This fixes a bug where the status attribute of FontFaceSet gets stuck
at "loading" when @font-face rule is removed while the font is loading.

Before this patch, font load completion was notified from
CSSFontFace::setLoadStatus() via m_segmentedFontFace, but if the
@font-face rule is detached, m_segmentedFontFace is null.
After this patch, FontFaceSet registers itself as an observer of
FontFace for load completion.

BUG=641322
==========

[Kunihiko Sakamoto, 2016-09-16 05:39:30]

On 2016/09/16 05:07:00, toyoshim wrote:
> In the CL description,
> > @font-face rule is detached m_segmentedFontFace is null.
> 
> Does this mean "... was detached, m_segmentedFontFace is null here"?
> Probably, inserting "," makes easy to understand this line.

Thanks, the description updated.

[Takashi Toyoshima, 2016-09-16 05:40:10]

lgtm with one oprional request on test.

[Takashi Toyoshima, 2016-09-16 05:40:50]

Oops, forgot to publish.

https://codereview.chromium.org/2340273002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/webfont/fontfaceset-status-attribute.html
(right):

https://codereview.chromium.org/2340273002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/webfont/fontfaceset-status-attribute.html:1:
<!DOCTYPE html>
I slightly prefer to keep the original test case (with new test style), and to
add new test case with removing css font as another test.

[Kunihiko Sakamoto, 2016-09-16 09:23:19]

The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 09:23:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 10:29:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 10:29:49]

Dry run: This issue passed the CQ dry run.

[Kunihiko Sakamoto, 2016-09-20 02:27:24]

ksakamoto@chromium.org changed reviewers:
+ kouhei@chromium.org

[Kunihiko Sakamoto, 2016-09-20 02:27:25]

+kouhei for OWNERs review

https://codereview.chromium.org/2340273002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/webfont/fontfaceset-status-attribute.html
(right):

https://codereview.chromium.org/2340273002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/webfont/fontfaceset-status-attribute.html:1:
<!DOCTYPE html>
On 2016/09/16 05:40:50, toyoshim wrote:
> I slightly prefer to keep the original test case (with new test style), and to
> add new test case with removing css font as another test.

Done.

[Kunihiko Sakamoto, 2016-09-26 08:49:51]

kouhei@: ping?

[kouhei (in TOK), 2016-09-26 09:57:27]

lgtm

[Kunihiko Sakamoto, 2016-09-27 01:15:46]

The CQ bit was checked by ksakamoto@chromium.org

[Kunihiko Sakamoto, 2016-09-27 01:15:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
toyoshim@chromium.org
Link to the patchset: https://codereview.chromium.org/2340273002/#ps60001
(title: "Separate test case")

[commit-bot: I haz the power, 2016-09-27 01:16:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 04:18:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 04:18:11]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Kunihiko Sakamoto, 2016-09-27 04:20:14]

The CQ bit was checked by ksakamoto@chromium.org

[commit-bot: I haz the power, 2016-09-27 04:20:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 05:18:43]

Description was changed from

==========
Fix FontFaceSet state getting stuck at loading

This fixes a bug where the status attribute of FontFaceSet gets stuck
at "loading" when @font-face rule is removed while the font is loading.

Before this patch, font load completion was notified from
CSSFontFace::setLoadStatus() via m_segmentedFontFace, but if the
@font-face rule is detached, m_segmentedFontFace is null.
After this patch, FontFaceSet registers itself as an observer of
FontFace for load completion.

BUG=641322
==========

to

==========
Fix FontFaceSet state getting stuck at loading

This fixes a bug where the status attribute of FontFaceSet gets stuck
at "loading" when @font-face rule is removed while the font is loading.

Before this patch, font load completion was notified from
CSSFontFace::setLoadStatus() via m_segmentedFontFace, but if the
@font-face rule is detached, m_segmentedFontFace is null.
After this patch, FontFaceSet registers itself as an observer of
FontFace for load completion.

BUG=641322
==========

[commit-bot: I haz the power, 2016-09-27 05:18:44]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-09-27 05:21:53]

Description was changed from

==========
Fix FontFaceSet state getting stuck at loading

This fixes a bug where the status attribute of FontFaceSet gets stuck
at "loading" when @font-face rule is removed while the font is loading.

Before this patch, font load completion was notified from
CSSFontFace::setLoadStatus() via m_segmentedFontFace, but if the
@font-face rule is detached, m_segmentedFontFace is null.
After this patch, FontFaceSet registers itself as an observer of
FontFace for load completion.

BUG=641322
==========

to

==========
Fix FontFaceSet state getting stuck at loading

This fixes a bug where the status attribute of FontFaceSet gets stuck
at "loading" when @font-face rule is removed while the font is loading.

Before this patch, font load completion was notified from
CSSFontFace::setLoadStatus() via m_segmentedFontFace, but if the
@font-face rule is detached, m_segmentedFontFace is null.
After this patch, FontFaceSet registers itself as an observer of
FontFace for load completion.

BUG=641322

Committed: https://crrev.com/035a2a978b7ec4f87439c355af25941fb0b9cfca
Cr-Commit-Position: refs/heads/master@{#421114}
==========

[commit-bot: I haz the power, 2016-09-27 05:21:54]

Patchset 2 (id:??) landed as
https://crrev.com/035a2a978b7ec4f87439c355af25941fb0b9cfca
Cr-Commit-Position: refs/heads/master@{#421114}