third_party/WebKit/Source/core/css/FontFace.cpp - Issue 2340273002: Fix FontFaceSet state getting stuck at loading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/FontFace.cpp

Issue 2340273002: Fix FontFaceSet state getting stuck at loading (Closed)

Patch Set: Separate test case Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/FontFace.cpp

diff --git a/third_party/WebKit/Source/core/css/FontFace.cpp b/third_party/WebKit/Source/core/css/FontFace.cpp

index 98845b6f9edc1cda713bbd341d6e31999efc6f10..644bfc205f9a99b42578175a64c709ea25c1592e 100644

--- a/third_party/WebKit/Source/core/css/FontFace.cpp

+++ b/third_party/WebKit/Source/core/css/FontFace.cpp

@@ -381,6 +381,11 @@ ScriptPromise FontFace::load(ScriptState* scriptState)

void FontFace::loadWithCallback(LoadFontCallback* callback, ExecutionContext* context)

{

loadInternal(context);

+ addCallback(callback);

+void FontFace::addCallback(LoadFontCallback* callback)

if (m_status == Loaded)

callback->notifyLoaded(this);

else if (m_status == Error)