Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2339983006: Update watchlists for sensors, battery and spellcheck. (Closed)

Created:
4 years, 3 months ago by timvolodine
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update watchlists for sensors, battery and spellcheck. {device/sensors/} created in https://codereview.chromium.org/2037513002 {content/renderer/battery_status/} moved in https://codereview.chromium.org/1538803002 {chrome/browser/tab_contents/spellchecker, chrome/browser/tab_contents/spelling_menu} moved in https://codereview.chromium.org/178193005 to chrome/browser/renderer_context_menu/ spellchecker_* files further removed in https://codereview.chromium.org/1357393002 {chrome/common/spellcheck_} moved to component in https://codereview.chromium.org/2177343002/ {chrome/renderer/spellchecker/} moved to component in https://codereview.chromium.org/2198143002/ BUG=629609 Committed: https://crrev.com/8cdb94cb9311400e353c03fdb9552e32570da426 Cr-Commit-Position: refs/heads/master@{#420311}

Patch Set 1 #

Patch Set 2 : some fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M WATCHLISTS View 1 6 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
timvolodine
mlamouri@: battery and sensors groby@, rouslan@: spellcheck
4 years, 3 months ago (2016-09-16 16:47:49 UTC) #6
groby-ooo-7-16
On 2016/09/16 16:47:49, timvolodine wrote: > mlamouri@: battery and sensors > groby@, rouslan@: spellcheck LGTM
4 years, 3 months ago (2016-09-16 17:59:02 UTC) #9
please use gerrit instead
lgtm
4 years, 3 months ago (2016-09-19 15:53:37 UTC) #10
mlamouri (slow - plz ping)
lgtm
4 years, 3 months ago (2016-09-22 09:27:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339983006/20001
4 years, 3 months ago (2016-09-22 12:09:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 12:17:44 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 12:20:23 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8cdb94cb9311400e353c03fdb9552e32570da426
Cr-Commit-Position: refs/heads/master@{#420311}

Powered by Google App Engine
This is Rietveld 408576698