Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1357393002: Desktop context menu reorganisation (Closed)

Created:
5 years, 3 months ago by edwardjung
Modified:
4 years, 9 months ago
CC:
chromium-reviews, tfarina, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Desktop context menu reorganisation + Reorganising the context menus into better groupings + Renaming menu item labels for consistency + Removing items that are rarely used and have other access points (e.g. spellchecker submenu, page info) + Fix writing redirection UMA metrics collection BUG=506874 Committed: https://crrev.com/5414139041953f2b558cfb0fdf8a4927a19a3144 Cr-Commit-Position: refs/heads/master@{#351094}

Patch Set 1 #

Patch Set 2 : Remove spellchecker_submenu_observer #

Patch Set 3 : Remove spellchecker submenu browser tests #

Patch Set 4 : Update spelling menu observer browser tests #

Patch Set 5 : Remove SeparatorAfterSuggestions test, as there is no longer a separator after suggestions #

Patch Set 6 : #

Total comments: 36

Patch Set 7 : Address review comments, styling and tests #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -826 lines) Patch
M chrome/app/generated_resources.grd View 1 14 chunks +17 lines, -51 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.h View 1 2 3 4 5 5 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 2 3 4 5 6 7 19 chunks +156 lines, -161 lines 0 comments Download
D chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h View 1 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/renderer_context_menu/spellchecker_submenu_observer_browsertest.cc View 1 1 chunk +0 lines, -154 lines 0 comments Download
D chrome/browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc View 1 1 chunk +0 lines, -188 lines 0 comments Download
D chrome/browser/renderer_context_menu/spellchecker_submenu_observer_mac.cc View 1 1 chunk +0 lines, -132 lines 0 comments Download
M chrome/browser/renderer_context_menu/spelling_menu_observer.cc View 1 2 3 4 5 6 3 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc View 1 2 3 4 5 6 8 chunks +28 lines, -60 lines 0 comments Download
M chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (10 generated)
edwardjung
5 years, 2 months ago (2015-09-25 19:34:32 UTC) #3
edwardjung
5 years, 2 months ago (2015-09-25 19:34:32 UTC) #4
edwardjung
Hi, all, please take a look respectively at the following files: avi: chrome/browser/renderer_context_menu/* chrome/browser/ui/cocoa/renderer_context_menu/* chrome/browser/ui/views/renderer_context_menu/* ...
5 years, 2 months ago (2015-09-25 19:47:59 UTC) #7
sky
*gypi has * as owners, so anyone can review the changes. -sky
5 years, 2 months ago (2015-09-25 20:15:58 UTC) #9
Ilya Sherman
histograms.xml lgtm
5 years, 2 months ago (2015-09-26 00:19:19 UTC) #10
Avi (use Gerrit)
Lots of weird indenting; you might want to "git cl format" it. https://codereview.chromium.org/1357393002/diff/100001/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc ...
5 years, 2 months ago (2015-09-26 02:26:15 UTC) #11
edwardjung
> *gypi has * as owners, so anyone can review the changes. > -sky Doh, ...
5 years, 2 months ago (2015-09-28 14:11:26 UTC) #13
sky
One line change in chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc LGTM
5 years, 2 months ago (2015-09-28 15:23:31 UTC) #14
Avi (use Gerrit)
lgtm 👍
5 years, 2 months ago (2015-09-28 15:29:22 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357393002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357393002/140001
5 years, 2 months ago (2015-09-28 16:26:24 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-28 16:35:59 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357393002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357393002/140001
5 years, 2 months ago (2015-09-28 18:52:13 UTC) #22
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 2 months ago (2015-09-28 19:15:20 UTC) #23
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/5414139041953f2b558cfb0fdf8a4927a19a3144 Cr-Commit-Position: refs/heads/master@{#351094}
5 years, 2 months ago (2015-09-28 19:16:35 UTC) #24
iakaox
+ Removing items that are rarely used and have other access points (e.g. spellchecker submenu, ...
5 years ago (2015-12-14 10:58:24 UTC) #25
ggpanta
On 2015/12/14 10:58:24, iakaox wrote: > + Removing items that are rarely used and have ...
5 years ago (2015-12-15 11:35:15 UTC) #26
edwardjung
Do you want to add your comment to the bug that's open: https://code.google.com/p/chromium/issues/detail?id=544234 We'll review ...
5 years ago (2015-12-15 12:00:09 UTC) #27
siteadmin
Please re-add "right-click change spell-check language option", or provide a means to add it manually, ...
4 years, 11 months ago (2016-01-08 08:12:25 UTC) #28
cpzhispania
On 2016/01/08 08:12:25, siteadmin wrote: > Please re-add "right-click change spell-check language option", or provide ...
4 years, 11 months ago (2016-01-18 16:39:22 UTC) #29
paulo.s.matos
On 2016/01/18 16:39:22, cpzhispania wrote: > On 2016/01/08 08:12:25, siteadmin wrote: > > Please re-add ...
4 years, 10 months ago (2016-02-11 11:30:25 UTC) #30
jean-marie.duno
On 2016/02/11 11:30:25, paulo.s.matos wrote: > On 2016/01/18 16:39:22, cpzhispania wrote: > > On 2016/01/08 ...
4 years, 9 months ago (2016-03-02 17:25:41 UTC) #31
serge
On 2016/03/02 17:25:41, jean-marie.duno wrote: > On 2016/02/11 11:30:25, paulo.s.matos wrote: > > On 2016/01/18 ...
4 years, 9 months ago (2016-03-09 08:44:11 UTC) #32
serge
4 years, 9 months ago (2016-03-09 08:48:05 UTC) #33
Message was sent while issue was closed.
On 2016/03/09 08:44:11, serge wrote:
> On 2016/03/02 17:25:41, jean-marie.duno wrote:
> > On 2016/02/11 11:30:25, paulo.s.matos wrote:
> > > On 2016/01/18 16:39:22, cpzhispania wrote:
> > > > On 2016/01/08 08:12:25, siteadmin wrote:
> > > > > Please re-add "right-click change spell-check language option", or
> provide
> > a
> > > > > means to add it manually, or a mean to roll-back chrome user version
and
> > > > > permanently disable chrome self-update feature to prevent future
> function
> > > > > breakage.
> > > > > 
> > > > > Thanks
> > > > 
> > > > Chiming in on this. Looking to roll-back to a version that has the
> > right-click
> > > > spell-checker lang switch. Chrome it's a pain to use without it, I use
> this
> > > > feature on a daily basis. Are you including mobile and tablet data sets
on
> > the
> > > > statistics you based this information on by any chance? Otherwise I
can't
> > > think
> > > > of a reason how this feature was marked as under-used.
> > > > 
> > > > Please bring back this functionality.
> > > 
> > > Please, rollback this change! Por favor, anulem esta alteração! Por favor,
> > > anulen este cambio! Per piacere, annullate questo cambiamento! S'il vous
> > plaît,
> > > annulez ce changement! (English/Portuguese/Spanish/Italian/French typer)
> > > 
> > > Same here, check it:
> > >
https://productforums.google.com/forum/#!msg/chrome/7T2ztGVpJBk/i6m7bVdmBQAJ
> > 
> > It is used !
> > On my company we are all using local and english language all the day.
> > The language switch is used many time per days !
> > 
> > Please roll back this change.
> 
> Please roll-back it!
> 
> How is possible automatically determine what language I need to write? Say
here
> I write "Presentation"... Just this word. Should I mean English word (OK) or
> maybe French (NOK, because of accent "Présentation")? Only I know what
language
> I would like to use, what a stupid movie from Google Stuff members!

I write "Presentation" as a texbox field. I need that this word be correct in
French... 
But stupid Chrome thinks that I wrote a English word, and does not underline
it...
I am not sure where and what kind of accent I should use in this French word, so
I have any way to test it, I should open Microsoft word, select text, select
French, and only then it underlines me the error... Before it worked in Chrome,
now it does not!

Bad guys !

Powered by Google App Engine
This is Rietveld 408576698