Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 178193005: Move render_view_context_menu.* related files out of tab_contents. (Closed)

Created:
6 years, 10 months ago by lazyboy
Modified:
6 years, 9 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, Avi (use Gerrit), jennb, creis+watch_chromium.org, benjhayden+dwatch_chromium.org, rpetterson, rouslan+spellwatch_chromium.org, dcheng, Dmitry Titov, jianli, ajwong+watch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move render_view_context_menu.* and related files out of tab_contents. Move it to a top level directory under called c/b/context_menu/* BUG=None Test=No functionality change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253786

Patch Set 1 #

Patch Set 2 : render_view_context_menu move only change, reverted other, checked linux/chromeos/mac compile. #

Patch Set 3 : Fix mac build + build file ordering. #

Patch Set 4 : Remove incorrectly added files. #

Patch Set 5 : context_menu->renderer_context_menu for disambiguation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -6057 lines) Patch
M chrome/browser/apps/app_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/web_view_interactive_browsertest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_context_menu_observer.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/referrer_policy_browsertest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/renderer_context_menu/OWNERS View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/renderer_context_menu/render_view_context_menu.h View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/renderer_context_menu/render_view_context_menu_browsertest_util.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/renderer_context_menu/render_view_context_menu_browsertest_util.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/renderer_context_menu/render_view_context_menu_observer.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/renderer_context_menu/render_view_context_menu_observer.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/renderer_context_menu/render_view_context_menu_test_util.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/renderer_context_menu/spellchecker_submenu_observer_browsertest.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/renderer_context_menu/spellchecker_submenu_observer_mac.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/renderer_context_menu/spelling_bubble_model.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/renderer_context_menu/spelling_bubble_model.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/renderer_context_menu/spelling_menu_observer.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/renderer_context_menu/spelling_menu_observer.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/tab_contents/render_view_context_menu.h View 1 chunk +0 lines, -300 lines 0 comments Download
D chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +0 lines, -2120 lines 0 comments Download
D chrome/browser/tab_contents/render_view_context_menu_browsertest.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D chrome/browser/tab_contents/render_view_context_menu_browsertest_util.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/tab_contents/render_view_context_menu_browsertest_util.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/tab_contents/render_view_context_menu_observer.h View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/browser/tab_contents/render_view_context_menu_observer.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/tab_contents/render_view_context_menu_test_util.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/tab_contents/render_view_context_menu_test_util.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/tab_contents/render_view_context_menu_unittest.cc View 1 chunk +0 lines, -291 lines 0 comments Download
D chrome/browser/tab_contents/spellchecker_submenu_observer.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/tab_contents/spellchecker_submenu_observer_browsertest.cc View 1 chunk +0 lines, -157 lines 0 comments Download
D chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc View 1 chunk +0 lines, -186 lines 0 comments Download
D chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/browser/tab_contents/spelling_bubble_model.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/tab_contents/spelling_bubble_model.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/tab_contents/spelling_menu_observer.h View 1 chunk +0 lines, -120 lines 0 comments Download
D chrome/browser/tab_contents/spelling_menu_observer.cc View 1 chunk +0 lines, -420 lines 0 comments Download
D chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc View 1 chunk +0 lines, -481 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/tab_contents/render_view_context_menu_mac.h View 1 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_contents/render_view_context_menu_mac.mm View 1 1 chunk +0 lines, -279 lines 0 comments Download
A + chrome/browser/ui/gtk/renderer_context_menu/render_view_context_menu_gtk.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/gtk/renderer_context_menu/render_view_context_menu_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents/render_view_context_menu_gtk.h View 1 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/ui/gtk/tab_contents/render_view_context_menu_gtk.cc View 1 1 chunk +0 lines, -242 lines 0 comments Download
M chrome/browser/ui/panels/panel_extension_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_win.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h View 1 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc View 1 1 chunk +0 lines, -211 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/render_view_context_menu_win.h View 1 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/render_view_context_menu_win.cc View 1 1 chunk +0 lines, -78 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 4 chunks +22 lines, -22 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
lazyboy
6 years, 10 months ago (2014-02-26 04:53:53 UTC) #1
Avi (use Gerrit)
lgtm stamp
6 years, 10 months ago (2014-02-26 16:55:01 UTC) #2
lazyboy
+sky@chromium.org for OWNERS in chrome/browser/*, adding directory chrome/browser/context_menu/*
6 years, 10 months ago (2014-02-26 17:36:01 UTC) #3
sky
We have a bunch of context menus in chrome. I think the expectation with this ...
6 years, 10 months ago (2014-02-26 18:21:13 UTC) #4
lazyboy
On 2014/02/26 18:21:13, sky wrote: > We have a bunch of context menus in chrome. ...
6 years, 10 months ago (2014-02-26 19:22:48 UTC) #5
sky
LGTM
6 years, 10 months ago (2014-02-26 21:37:28 UTC) #6
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 10 months ago (2014-02-27 00:45:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/178193005/80001
6 years, 10 months ago (2014-02-27 00:46:50 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 13:41:24 UTC) #9
Message was sent while issue was closed.
Change committed as 253786

Powered by Google App Engine
This is Rietveld 408576698