chrome/browser/resources/settings/reset_page/reset_profile_dialog.js - Issue 2339853003: MD Settings: Fix Reset profile dialog scenario that causes a crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/reset_page/reset_profile_dialog.js

Issue 2339853003: MD Settings: Fix Reset profile dialog scenario that causes a crash. (Closed)

Patch Set: Fix more. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/reset_page/reset_profile_dialog.html ('K') | « chrome/browser/resources/settings/reset_page/reset_profile_dialog.html ('k') | chrome/test/data/webui/settings/reset_page_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/reset_page/reset_profile_dialog.js

diff --git a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js

index 5ac646ec0d36f751d76f2a932e7e214ee29c30d3..13153c55244aae4e5129752a9e8fc462c010c871 100644

--- a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js

+++ b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js

@@ -50,7 +50,8 @@ Polymer({

this.browserProxy_.performResetProfileSettings(

this.$.sendSettings.checked).then(function() {

this.clearingInProgress_ = false;

- this.$.dialog.close();

+ if (this.$.dialog.open)

+ this.$.dialog.close();

this.dispatchEvent(new CustomEvent('reset-done'));

Dan Beam 2016/09/15 21:15:40 why isn't this |this.fire('reset-done')|? what's

dpapad 2016/09/20 00:52:36 No good reason. Changed to use fire().

}.bind(this));