Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7420)

Unified Diff: chrome/browser/resources/settings/reset_page/reset_profile_dialog.html

Issue 2339853003: MD Settings: Fix Reset profile dialog scenario that causes a crash. (Closed)
Patch Set: Fix more. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
diff --git a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
index e337d8028611755ccd453667a10b566572a97a30..79b5fdc552fcdbfaa9c4705a902e166c5058c40e 100644
--- a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
+++ b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
@@ -18,6 +18,10 @@
text-decoration: none;
vertical-align: middle;
}
+
+ paper-spinner {
+ margin: 0 8px;
+ }
</style>
<dialog is="cr-dialog" id="dialog">
<div class="title">$i18n{resetPageTitle}</div>
@@ -33,7 +37,9 @@
<paper-spinner id="resetSpinner" active="[[clearingInProgress_]]">
Dan Beam 2016/09/15 21:15:40 is this spinner the right size? it looks too big
dpapad 2016/09/20 00:52:36 See http://imgur.com/a/6WO3s. It is 28x28, so sizi
</paper-spinner>
<paper-button class="cancel-button" on-tap="onCancelTap_"
- id="cancel">$i18n{cancel}</paper-button>
+ id="cancel" disabled="[[clearingInProgress_]]">
Dan Beam 2016/09/15 21:15:40 wat? you're disabling the /cancel/ button? why n
dpapad 2016/09/20 00:52:36 The clearing button is already being disabled, usi
+ $i18n{cancel}
+ </paper-button>
<paper-button class="action-button" on-tap="onResetTap_"
id="reset" disabled="[[clearingInProgress_]]">
$i18n{resetPageCommit}

Powered by Google App Engine
This is Rietveld 408576698