Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: chrome/test/data/webui/settings/reset_page_test.js

Issue 2339853003: MD Settings: Fix Reset profile dialog scenario that causes a crash. (Closed)
Patch Set: Fix more. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/reset_page_test.js
diff --git a/chrome/test/data/webui/settings/reset_page_test.js b/chrome/test/data/webui/settings/reset_page_test.js
index ee4172f8f4004f3951de5c2e678471b1b23d22bb..00641cb9150836a5e2944ef86019a032d4de65cb 100644
--- a/chrome/test/data/webui/settings/reset_page_test.js
+++ b/chrome/test/data/webui/settings/reset_page_test.js
@@ -149,9 +149,9 @@ cr.define('settings_reset_page', function() {
// Open reset profile dialog.
MockInteractions.tap(resetPage.$.resetProfile);
+ Polymer.dom.flush();
var dialog = resetPage.$$('settings-reset-profile-dialog');
assertTrue(!!dialog);
- assertTrue(dialog.$.dialog.open);
var onDialogClosed = new Promise(
function(resolve, reject) {
dialog.addEventListener('close', function() {
@@ -162,6 +162,7 @@ cr.define('settings_reset_page', function() {
return resetPageBrowserProxy.whenCalled(
'onShowResetProfileDialog').then(function() {
+ assertTrue(dialog.$.dialog.open);
closeDialogFn(dialog);
return Promise.all([
onDialogClosed,
@@ -189,6 +190,7 @@ cr.define('settings_reset_page', function() {
test(TestNames.ResetProfileDialogAction, function() {
// Open reset profile dialog.
MockInteractions.tap(resetPage.$.resetProfile);
+ Polymer.dom.flush();
var dialog = resetPage.$$('settings-reset-profile-dialog');
assertTrue(!!dialog);
@@ -202,6 +204,7 @@ cr.define('settings_reset_page', function() {
assertFalse(dialog.$.resetSpinner.active);
MockInteractions.tap(dialog.$.reset);
assertTrue(dialog.$.reset.disabled);
+ assertTrue(dialog.$.cancel.disabled);
assertTrue(dialog.$.resetSpinner.active);
return resetPageBrowserProxy.whenCalled(
'performResetProfileSettings');

Powered by Google App Engine
This is Rietveld 408576698