Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2339793002: Handle newCursorPosition correctly for Android's commitText() (Closed)
Patch Set: Fix compile error (rebased on r418371) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index 1a2a957c6b82a6b5960d0d1ddbbb7c016dc17962..a69995d7d3a426ca11657f123a8234d91eab26c1 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -141,9 +141,8 @@ public:
const WebVector<WebCompositionUnderline>& underlines,
int selectionStart,
int selectionEnd) override;
- bool confirmComposition() override;
- bool confirmComposition(ConfirmCompositionBehavior selectionBehavior) override;
- bool confirmComposition(const WebString& text) override;
+ bool commitText(const WebString& text, int relativeCaretPosition) override;
+ bool finishComposingText(ConfirmCompositionBehavior selectionBehavior) override;
WebRange compositionRange() override;
WebTextInputInfo textInputInfo() override;
WebTextInputType textInputType() override;
@@ -563,8 +562,6 @@ private:
// Returns true if the event was actually processed.
bool keyEventDefault(const WebKeyboardEvent&);
- bool confirmComposition(const WebString& text, ConfirmCompositionBehavior);
-
// Returns true if the view was scrolled.
bool scrollViewWithKeyboard(int keyCode, int modifiers);
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698