Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: third_party/WebKit/Source/web/WebViewFrameWidget.cpp

Issue 2339793002: Handle newCursorPosition correctly for Android's commitText() (Closed)
Patch Set: Fix compile error (rebased on r418371) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.h ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewFrameWidget.cpp
diff --git a/third_party/WebKit/Source/web/WebViewFrameWidget.cpp b/third_party/WebKit/Source/web/WebViewFrameWidget.cpp
index b7f29e94ed154070d6bca98ea0337b905ede8f56..a70cb9644d28ebd648ff1bde2d79d5a41ae717f3 100644
--- a/third_party/WebKit/Source/web/WebViewFrameWidget.cpp
+++ b/third_party/WebKit/Source/web/WebViewFrameWidget.cpp
@@ -137,19 +137,14 @@ bool WebViewFrameWidget::setComposition(
return m_webView->setComposition(text, underlines, selectionStart, selectionEnd);
}
-bool WebViewFrameWidget::confirmComposition()
+bool WebViewFrameWidget::finishComposingText(ConfirmCompositionBehavior selectionBehavior)
{
- return m_webView->confirmComposition();
+ return m_webView->finishComposingText(selectionBehavior);
}
-bool WebViewFrameWidget::confirmComposition(ConfirmCompositionBehavior selectionBehavior)
+bool WebViewFrameWidget::commitText(const WebString& text, int relativeCaretPosition)
{
- return m_webView->confirmComposition(selectionBehavior);
-}
-
-bool WebViewFrameWidget::confirmComposition(const WebString& text)
-{
- return m_webView->confirmComposition(text);
+ return m_webView->commitText(text, relativeCaretPosition);
}
WebRange WebViewFrameWidget::compositionRange()
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.h ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698