Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2339793002: Handle newCursorPosition correctly for Android's commitText() (Closed)
Patch Set: Fix compile error (rebased on r418371) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 const WebFloatSize& elasticOverscrollDelta, 134 const WebFloatSize& elasticOverscrollDelta,
135 float pageScaleDelta, 135 float pageScaleDelta,
136 float topControlsShownRatioDelta) override; 136 float topControlsShownRatioDelta) override;
137 void mouseCaptureLost() override; 137 void mouseCaptureLost() override;
138 void setFocus(bool enable) override; 138 void setFocus(bool enable) override;
139 bool setComposition( 139 bool setComposition(
140 const WebString& text, 140 const WebString& text,
141 const WebVector<WebCompositionUnderline>& underlines, 141 const WebVector<WebCompositionUnderline>& underlines,
142 int selectionStart, 142 int selectionStart,
143 int selectionEnd) override; 143 int selectionEnd) override;
144 bool confirmComposition() override; 144 bool commitText(const WebString& text, int relativeCaretPosition) override;
145 bool confirmComposition(ConfirmCompositionBehavior selectionBehavior) overri de; 145 bool finishComposingText(ConfirmCompositionBehavior selectionBehavior) overr ide;
146 bool confirmComposition(const WebString& text) override;
147 WebRange compositionRange() override; 146 WebRange compositionRange() override;
148 WebTextInputInfo textInputInfo() override; 147 WebTextInputInfo textInputInfo() override;
149 WebTextInputType textInputType() override; 148 WebTextInputType textInputType() override;
150 WebColor backgroundColor() const override; 149 WebColor backgroundColor() const override;
151 WebPagePopup* pagePopup() const override; 150 WebPagePopup* pagePopup() const override;
152 bool selectionBounds(WebRect& anchor, WebRect& focus) const override; 151 bool selectionBounds(WebRect& anchor, WebRect& focus) const override;
153 bool selectionTextDirection(WebTextDirection& start, WebTextDirection& end) const override; 152 bool selectionTextDirection(WebTextDirection& start, WebTextDirection& end) const override;
154 bool isSelectionAnchorFirst() const override; 153 bool isSelectionAnchorFirst() const override;
155 WebRange caretOrSelectionRange() override; 154 WebRange caretOrSelectionRange() override;
156 void setTextDirection(WebTextDirection) override; 155 void setTextDirection(WebTextDirection) override;
(...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after
556 explicit WebViewImpl(WebViewClient*, WebPageVisibilityState); 555 explicit WebViewImpl(WebViewClient*, WebPageVisibilityState);
557 ~WebViewImpl() override; 556 ~WebViewImpl() override;
558 557
559 int textInputFlags(); 558 int textInputFlags();
560 559
561 WebString inputModeOfFocusedElement(); 560 WebString inputModeOfFocusedElement();
562 561
563 // Returns true if the event was actually processed. 562 // Returns true if the event was actually processed.
564 bool keyEventDefault(const WebKeyboardEvent&); 563 bool keyEventDefault(const WebKeyboardEvent&);
565 564
566 bool confirmComposition(const WebString& text, ConfirmCompositionBehavior);
567
568 // Returns true if the view was scrolled. 565 // Returns true if the view was scrolled.
569 bool scrollViewWithKeyboard(int keyCode, int modifiers); 566 bool scrollViewWithKeyboard(int keyCode, int modifiers);
570 567
571 void hideSelectPopup(); 568 void hideSelectPopup();
572 569
573 HitTestResult hitTestResultForRootFramePos(const IntPoint&); 570 HitTestResult hitTestResultForRootFramePos(const IntPoint&);
574 HitTestResult hitTestResultForViewportPos(const IntPoint&); 571 HitTestResult hitTestResultForViewportPos(const IntPoint&);
575 572
576 // Consolidate some common code between starting a drag over a target and 573 // Consolidate some common code between starting a drag over a target and
577 // updating a drag over a target. If we're starting a drag, |isEntering| 574 // updating a drag over a target. If we're starting a drag, |isEntering|
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 Persistent<ResizeViewportAnchor> m_resizeViewportAnchor; 776 Persistent<ResizeViewportAnchor> m_resizeViewportAnchor;
780 }; 777 };
781 778
782 // We have no ways to check if the specified WebView is an instance of 779 // We have no ways to check if the specified WebView is an instance of
783 // WebViewImpl because WebViewImpl is the only implementation of WebView. 780 // WebViewImpl because WebViewImpl is the only implementation of WebView.
784 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 781 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
785 782
786 } // namespace blink 783 } // namespace blink
787 784
788 #endif 785 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698