[Offline pages] Splitting Add and Update methods in OPMStore

[Offline pages] Splitting Add and Update methods in OPMStore

In OfflinePageMetadataStore the following changes:
* AddOfflinePage (for single item) is added
* UpdateOfflinePages (for multiple items) is added
* AddOrUpdateOfflinePage is removed.

Resulting changes:
* OfflinePageMetadataStoreSQL and OfflinePageTestStore are updated
  accordingly.
* Tests are updated.
* OfflinePageModelImpl usage of above functions is updated.

BUG=645522
Committed: https://crrev.com/9305bb6b94a0bf9ed2823037bd2c3314a793ecae
Cr-Commit-Position: refs/heads/master@{#418587}

[fgorski, 2016-09-13 21:05:01]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 21:05:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-09-13 21:50:25]

fgorski@chromium.org changed reviewers:
+ dewittj@chromium.org, dimich@chromium.org

[fgorski, 2016-09-13 21:50:26]

PTAL.

There are implementation details I want to change about Add and of course
signature change pending for the update callback, but this might stand as enough
work to break the AddOrUpdate apart and start working on individual pieces.

Let me know what you think.

[commit-bot: I haz the power, 2016-09-13 21:54:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 21:54:09]

Dry run: This issue passed the CQ dry run.

[dewittj, 2016-09-14 00:24:12]

this seems like a fine patch.  I think it lgtm, though I wouldn't mind seeing
some of the test cases you have TODO'd in this patch.

https://codereview.chromium.org/2339693002/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_model_impl.cc (right):

https://codereview.chromium.org/2339693002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model_impl.cc:335:
std::vector<OfflinePageItem> items;
nit:
std::vector<OfflinePageItem> items = { offline_page_item };

https://codereview.chromium.org/2339693002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model_impl.cc:758: result = status ==
OfflinePageMetadataStore::ALREADY_EXISTS
nit: make an else if or a switch statement and remove ternary operator.

[fgorski, 2016-09-14 03:54:22]

Addressed

https://codereview.chromium.org/2339693002/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_model_impl.cc (right):

https://codereview.chromium.org/2339693002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model_impl.cc:335:
std::vector<OfflinePageItem> items;
On 2016/09/14 00:24:11, dewittj wrote:
> nit:
> std::vector<OfflinePageItem> items = { offline_page_item };

Done.

https://codereview.chromium.org/2339693002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model_impl.cc:758: result = status ==
OfflinePageMetadataStore::ALREADY_EXISTS
On 2016/09/14 00:24:11, dewittj wrote:
> nit: make an else if or a switch statement and remove ternary operator.

Done.

[fgorski, 2016-09-14 03:54:42]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-09-14 03:54:42]

The patchset sent to the CQ was uploaded after l-g-t-m from dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/2339693002/#ps20001
(title: "Addressing feedback")

[commit-bot: I haz the power, 2016-09-14 03:55:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 04:51:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 04:51:26]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[fgorski, 2016-09-14 16:03:34]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2016-09-14 16:03:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 16:44:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-14 16:46:15]

Description was changed from

==========
[Offline pages] Splitting Add and Update methods in OPMStore

In OfflinePageMetadataStore the following changes:
* AddOfflinePage (for single item) is added
* UpdateOfflinePages (for multiple items) is added
* AddOrUpdateOfflinePage is removed.

Resulting changes:
* OfflinePageMetadataStoreSQL and OfflinePageTestStore are updated
  accordingly.
* Tests are updated.
* OfflinePageModelImpl usage of above functions is updated.

BUG=645522
==========

to

==========
[Offline pages] Splitting Add and Update methods in OPMStore

In OfflinePageMetadataStore the following changes:
* AddOfflinePage (for single item) is added
* UpdateOfflinePages (for multiple items) is added
* AddOrUpdateOfflinePage is removed.

Resulting changes:
* OfflinePageMetadataStoreSQL and OfflinePageTestStore are updated
  accordingly.
* Tests are updated.
* OfflinePageModelImpl usage of above functions is updated.

BUG=645522

Committed: https://crrev.com/9305bb6b94a0bf9ed2823037bd2c3314a793ecae
Cr-Commit-Position: refs/heads/master@{#418587}
==========

[commit-bot: I haz the power, 2016-09-14 16:46:16]

Patchset 2 (id:??) landed as
https://crrev.com/9305bb6b94a0bf9ed2823037bd2c3314a793ecae
Cr-Commit-Position: refs/heads/master@{#418587}