[Offline pages] Splitting Add and Update methods in OPMStore

components/offline_pages/offline_page_test_store.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_test_store.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 16 matching lines @@
   if (scenario_ == TestScenario::LOAD_FAILED) {
     load_status = OfflinePageMetadataStore::STORE_LOAD_FAILED;
     offline_pages_.clear();
   } else {
     load_status = OfflinePageMetadataStore::LOAD_SUCCEEDED;
   }
   task_runner_->PostTask(FROM_HERE,
                          base::Bind(callback, load_status, GetAllPages()));
 }
 
-void OfflinePageTestStore::AddOrUpdateOfflinePage(
-    const OfflinePageItem& offline_page,
-    const UpdateCallback& callback) {
-  last_saved_page_ = offline_page;
-  bool result = scenario_ != TestScenario::WRITE_FAILED;
-  if (result)
+void OfflinePageTestStore::AddOfflinePage(const OfflinePageItem& offline_page,
+                                          const AddCallback& callback) {
+  // TODO(fgorski): Add and cover scenario with existing item.
+  OfflinePageMetadataStore::ItemActionStatus result;
+  if (scenario_ == TestScenario::SUCCESSFUL) {
     offline_pages_[offline_page.offline_id] = offline_page;
+    last_saved_page_ = offline_page;
+    result = OfflinePageMetadataStore::SUCCESS;
+  } else if (scenario_ == TestScenario::WRITE_FAILED) {
+    result = OfflinePageMetadataStore::STORE_ERROR;
+  }
   if (!callback.is_null())
     task_runner_->PostTask(FROM_HERE, base::Bind(callback, result));
 }
+
+void OfflinePageTestStore::UpdateOfflinePages(
+    const std::vector<OfflinePageItem>& pages,
+    const UpdateCallback& callback) {
+  bool result = scenario_ != TestScenario::WRITE_FAILED;
+  if (result) {
+    // TODO(fgorski): Cover scenario, where new items are being created, while
+    // they shouldn't.
+    for (auto& page : pages) {
+      offline_pages_[page.offline_id] = page;
+      last_saved_page_ = page;
+    }
+  }
+  if (!callback.is_null())
+    task_runner_->PostTask(FROM_HERE, base::Bind(callback, result));
+}
 
 void OfflinePageTestStore::RemoveOfflinePages(
     const std::vector<int64_t>& offline_ids,
     const UpdateCallback& callback) {
   ASSERT_FALSE(offline_ids.empty());
   bool result = false;
   if (scenario_ != TestScenario::REMOVE_FAILED) {
     for (const auto& offline_id : offline_ids) {
       auto iter = offline_pages_.find(offline_id);
       if (iter != offline_pages_.end()) {
@@ skipping 29 matching lines @@
   for (const auto& id_page_pair : offline_pages_)
     offline_pages.push_back(id_page_pair.second);
   return offline_pages;
 }
 
 void OfflinePageTestStore::ClearAllPages() {
   offline_pages_.clear();
 }
 
 }  // namespace offline_pages