Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: components/offline_pages/offline_page_metadata_store_sql.h

Issue 2339693002: [Offline pages] Splitting Add and Update methods in OPMStore (Closed)
Patch Set: Addressing feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_metadata_store_sql.h
diff --git a/components/offline_pages/offline_page_metadata_store_sql.h b/components/offline_pages/offline_page_metadata_store_sql.h
index cac358a4ee944a2cf4f07dabfcbf4cd6cba890fd..8f941cc10ce509a7a5d271eac7788838205da265 100644
--- a/components/offline_pages/offline_page_metadata_store_sql.h
+++ b/components/offline_pages/offline_page_metadata_store_sql.h
@@ -59,8 +59,10 @@ class OfflinePageMetadataStoreSQL : public OfflinePageMetadataStore {
// Implementation methods.
void GetOfflinePages(const LoadCallback& callback) override;
- void AddOrUpdateOfflinePage(const OfflinePageItem& offline_page,
- const UpdateCallback& callback) override;
+ void AddOfflinePage(const OfflinePageItem& offline_page,
+ const AddCallback& callback) override;
+ void UpdateOfflinePages(const std::vector<OfflinePageItem>& pages,
+ const UpdateCallback& callback) override;
void RemoveOfflinePages(const std::vector<int64_t>& offline_ids,
const UpdateCallback& callback) override;
void Reset(const ResetCallback& callback) override;

Powered by Google App Engine
This is Rietveld 408576698